MarquezProject / marquez

Collect, aggregate, and visualize a data ecosystem's metadata
https://marquezproject.ai
Apache License 2.0
1.78k stars 320 forks source link

encodeURIComponent namespace and name in GET (column)lineage requests #2984

Closed MaartenHubrechts closed 3 hours ago

MaartenHubrechts commented 12 hours ago

Problem

When a jobname contains special characters (such as +) the (column)lineage GET requests breaks because the URL used for the request isn't URL encoded. This leads to the lineage page not loading properly when clicking a job in the job pages that contains any of such special characters that break the request URL.

Solution

Use the encodeURIComponent function on both the namespace and name arguments so that special characters like + get encoded to %2B. This approach is also used in the datasets and jobs requests.

Checklist

boring-cyborg[bot] commented 12 hours ago

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

netlify[bot] commented 11 hours ago

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
Latest commit 3791ccaaa3fd94ed710ec464b2f084239fed3989
Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/673f7e287ab6be0008c6c7f2
boring-cyborg[bot] commented 3 hours ago

Great job! Congrats on your first merged pull request in the Marquez project!

codecov[bot] commented 3 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.19%. Comparing base (41d9d3d) to head (3791cca). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2984 +/- ## ========================================= Coverage 81.19% 81.19% Complexity 1506 1506 ========================================= Files 268 268 Lines 7360 7360 Branches 325 325 ========================================= Hits 5976 5976 Misses 1226 1226 Partials 158 158 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: