Closed MaartenHubrechts closed 3 hours ago
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).
Name | Link |
---|---|
Latest commit | 3791ccaaa3fd94ed710ec464b2f084239fed3989 |
Latest deploy log | https://app.netlify.com/sites/peppy-sprite-186812/deploys/673f7e287ab6be0008c6c7f2 |
Great job! Congrats on your first merged pull request in the Marquez project!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.19%. Comparing base (
41d9d3d
) to head (3791cca
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Problem
When a jobname contains special characters (such as
+
) the (column)lineage GET requests breaks because the URL used for the request isn't URL encoded. This leads to the lineage page not loading properly when clicking a job in the job pages that contains any of such special characters that break the request URL.Solution
Use the
encodeURIComponent
function on both thenamespace
andname
arguments so that special characters like+
get encoded to%2B
. This approach is also used in the datasets and jobs requests.Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)