Technical suggestions - Githubissues

MarshP / dcss-morgue-analyser

A Python program to analyse your DCSS morgue folder, collate metrics, spot patterns and give hints.

The Unlicense

2 stars 0 forks source link

Technical suggestions #6

Closed oschwab closed 7 years ago

oschwab commented 7 years ago

Here's just a bunch of suggestions I get from reading the source code

receive parameters from command line (see how I did it in death stats )
separate information acquisition from presentation : store the information extracted from morgue in data structures ( classes or lists or tuple , or whatever) , and later pass it to a (class,function) that will present it (in Markdown for the moment, but we could later imagine a GUI, raw text, HTML, or other formats )

MarshP commented 7 years ago

Okay, first I intend to do is the second. I want to refactor anyway to make the functions less huge.

oschwab commented 7 years ago

Hey,

If you want , I prepare the first option on my fork. the plan : a Configuration object ( containing morgue path, output type , ...) , filled by command line, that you can pass around in every functions / objects.

MarshP commented 7 years ago

Yes! I'm going to be out of action for quite a while. Maybe even much of the winter. Feel free to do as you will!

oschwab commented 7 years ago

As you want, @MarshP , but may be that if your first intention was to learn python, It would be better if I create my own project on my side ?

MarshP commented 7 years ago

Yes. Do what you will with my code, such as it is. Later I'll borrow from yours!