Add method to send post with multiple attached photos

MarshalX / atproto

The AT Protocol (🦋 Bluesky) SDK for Python 🐍

https://atproto.blue

MIT License

267 stars 29 forks source link

Add method to send post with multiple attached photos #313

Closed ryoryo25 closed 3 months ago

ryoryo25 commented 4 months ago

Description

I've added a function send_images to send a post with multiple attached images.

Changes

Add function send_images to class Client & AsyncClient
Rewrite function send_image using send_images (to keep backward compatibility)
Add an example of usage of send_images

MarshalX commented 4 months ago

Hi! Thank you for contributing! I saw that many people looking for this method. Backward compatibility is awesome. A few notes before deep diving into code:

we write sync Client and then auto-generate async version. Looks like the generator failed. Probably you wrote the async version by hand. Could you pls fix it?
speaking of blobls upload in the async version could we try to upload blobs simultaneously? For example, using asyncio.gather. I mean and don't see the reason to wait to upload the previous image to upload a new one
check on 4 images and no more should be covered already by the model. I guess we could delete this if from here

ryoryo25 commented 4 months ago

Thank you for reviewing my code! I revised the following parts you mentioned.

Revert the async version of Client
Delete validation for the number of images
Modify the code generator of AsyncClient to generate code for uploading blobs simultaneously by using asyncio.gather
```
uploads = [self.upload_blob(i) for i in images]
```
converts to
```
uploads = asyncio.gather(*[self.upload_blob(i) for i in images])
```

ryoryo25 commented 3 months ago

I've fixed the parts you mentioned. I think CI would be passed.