Closed MarshalX closed 7 months ago
Comparing optimize-string-encoding
(1dbfbbc) with main
(1c0df5e)
⚡ 3
improvements
✅ 189
untouched benchmarks
Benchmark | main |
optimize-string-encoding |
Change | |
---|---|---|---|---|
⚡ | test_dag_cbor_decode_fixtures[garbage-06] |
91 µs | 82.2 µs | +10.61% |
⚡ | test_dag_cbor_decode_fixtures[garbage-09] |
117.6 µs | 104.7 µs | +12.32% |
⚡ | test_dag_cbor_decode_fixtures[garbage-23] |
75.5 µs | 67 µs | +12.68% |
weeelll requires more investigation
now twitter.json feels a little bit better (as expected in theory)
now it's even better!
explanation:
read_str
performsfrom_utf8
in rust side which is not necessary because performed from CPython side tootodo: investigate possibilities of invalid utf8 strings here and how it be handled