search

MarshalX / tgcalls

Voice chats, private incoming and outgoing calls in Telegram for Developers
https://t.me/tgcallslib
GNU Lesser General Public License v3.0
516 stars 91 forks source link

Improve logger messages #119

Closed rojvv closed 3 years ago

buddhhu commented 3 years ago

Something useful will be a better pr igšŸŒ

TheHamkerCat commented 3 years ago

lol

rojvv commented 3 years ago

@TheHamkerCat you were not supposed to say that. See the diff.

MarshalX commented 3 years ago

Why don't you want to use infinitives?

rojvv commented 3 years ago

@MarshalX because you're not talking about something that is 100% done, but you talk about something is about to be tried to be done?

MarshalX commented 3 years ago

@MarshalX because you're not talking about something that is 100% done, but you talk about something is about to be tried to be done?

To mark long action I use double and triple dots in the end of log messageā€¦

rojvv commented 3 years ago

@MarshalX because you're not talking about something that is 100% done, but you talk about something is about to be tried to be done?

To mark long action I use double and triple dots in the end of log messageā€¦

So how is it related to using infinitive forms? i think the current way is cooler with triple dots. But it's what you say.

MarshalX commented 3 years ago

@rojserbest Continuous term use obliges to always have an expiration message (thst something was end). The infinitive is not obliges

rojvv commented 3 years ago

@MarshalX

MarshalX commented 3 years ago

Pls review group call native file. There is log messages without dots in the end. And double dots instead of triple

MarshalX commented 3 years ago

logger.debug(f'Not equal ssrc. Expected: {ssrc}. Actual: {self.mtproto_bridge.my_ssrc}')

MarshalX commented 3 years ago

logger.debug('Duplicate SSRC')

MarshalX commented 3 years ago

Rly?

rojvv commented 3 years ago

Rly?

Yes, rly. :)