search

MarshalX / tgcalls

Voice chats, private incoming and outgoing calls in Telegram for Developers
https://t.me/tgcallslib
GNU Lesser General Public License v3.0
523 stars 93 forks source link

typo. #146

Closed xditya closed 3 years ago

MarshalX commented 3 years ago

In this case, you need to change the double quotes to single quotes.

rojvv commented 3 years ago

Mh, and:

The commit message might be changed.

MarshalX commented 3 years ago

@rojserbest Exception

rojvv commented 3 years ago

@MarshalX yes, it's not popular to have a full stop in the end of its first param.

xditya commented 3 years ago

Mh, and:

  • Why would one need a dot in...

    • exception message?
    • commit message?

The commit message might be changed.

That's basic punctuation. You should not have skipped your English classes, maybe :)

MarshalX commented 3 years ago

In this case, you need to change the double quotes to single quotes.

@xditya

rojvv commented 3 years ago

Mh, and:

  • Why would one need a dot in...

    • exception message?
    • commit message?

The commit message might be changed.

That's basic punctuation. You should not have skipped your English classes, maybe :)

That's basic Python standards. You shouldn't have skipped your Python classes too. :P

rojvv commented 3 years ago

image You looked too serious about periods, here you missed one here.

xditya commented 3 years ago

In this case, you need to change the double quotes to single quotes.

@xditya

Oh, okay

xditya commented 3 years ago

I don't mean to offend anyone by opening a pr. If contributing stuff triggers the other "contributors", I shall not do so anymore. Thanks.