MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.28k stars 771 forks source link

Version 3.2.5 Release is just Version 3.2.4? #1198

Closed berryelectronics closed 8 years ago

berryelectronics commented 8 years ago

Hey, just noticed that actually not a whole lot has changed since the update. I Also went through some files and tested if they are the same (with the Notepad++ Compare Plugin) and it seems like the Source code for the 3.2.5 and 3.2.4 are the same and dont match up with the Repos latest state. The only thing that seems that it changed that it doesnt includes Musixmatch anymore.

MarshallOfSound commented 8 years ago

Everything you have said is correct.

I'll be putting in a wiki entry explaining why shortly.

This is where the 3.2.5 came from FWIW

https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/tree/v3.2.5-patch

MarshallOfSound commented 8 years ago

https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/What-happened-with-3.2.5%3F

berryelectronics commented 8 years ago

Oh man, that is shitty, hope they didnt did anything more than just sending you that email

berryelectronics commented 8 years ago

http://about.musixmatch.com/apiterms 7.2 You shall NOT: 7.2.4 attempt to copy, collect or scrape data from the Site in any way other than through accessing the API with the User Authentication Key;

Well, the only way seems to use their API.

berryelectronics commented 8 years ago

https://github.com/pilu/musixmatch-node

jostrander commented 8 years ago

That'd be fine and dandy berry if the license wasn't $25,000 minimum per year.

berryelectronics commented 8 years ago

Holy sh.....didnt knew that lel.