MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.28k stars 767 forks source link

Dark theme color issues #130

Closed Talor-A closed 8 years ago

Talor-A commented 8 years ago

Using dark theme, when an item in the sidebar is selected, the grey highlight color is the same color as the subtitle text, looking like this: screenshot 8 screenshot 7 Why not replace the grey highlight color with the theme's custom color(blue in my case) and change subtitle text to white when selected?

screenshot 9 screenshot 10

EDIT: Here's some more issues with color. The shuffle icon doesn't follow custom theme, and the music visualizer for the currently playing song is not very visible for me.

MarshallOfSound commented 8 years ago
Devo7v commented 8 years ago

To add to this topic, the vertical lines for the pause icon should be white to match the other icons. The screenshot above shows the pause icon using the background color instead which doesn't seem consistent with the rest of the theme.

MarshallOfSound commented 8 years ago

Fixed issues upstream in gmusic-utils/gmusic-theme.js