MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 767 forks source link

flash player #133

Closed MRTrololololo closed 8 years ago

MRTrololololo commented 8 years ago

Keeps asking me for flash player, When i already have flash installed.

MarshallOfSound commented 8 years ago

Are you up to date? Flash player is actually included in the latest release...

MRTrololololo commented 8 years ago

Yes

MarshallOfSound commented 8 years ago

Can you ensure that their is a folder called "Resources" with a flash ppapi DLL file inside it in your install folder

MRTrololololo commented 8 years ago

there's no folder called Resources

MarshallOfSound commented 8 years ago

..... Doesn't sound like you are on version 2.0.2

Can you redownload the installer and install again. Uninstall the old one first

eturk1 commented 8 years ago

congrats on a stable release!

  1. still tiny UI on my 4K (ignoring display 150% scale)
  2. mini player scale is off
2016-01-06 1 2016-01-06

(see pics)

for future, maybe a check box on first install to opt in to beta ring? this way regular users by default don't get update notice until tested? (is there a UI element for seeing a settings panel?)

MarshallOfSound commented 8 years ago

Confirm the version number you downloaded. Was it 2.0.2

eturk1 commented 8 years ago

@MarshallOfSound I assume it's 2.0.2 as I uninstalled old, install from: https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/releases/tag/2.0.2

exe file is 1.0.0.0 though so can't confirm (see pic)

2016-01-06 2
MarshallOfSound commented 8 years ago

Hmmm, that's strange. Could you check control panel it should have the right version in the programs list.

And I think I will start up a beta stream, just looking at the best way to do it

eturk1 commented 8 years ago

yes, 2.0.2 in uninstaller

(see pic to better show scale between outlook UI & GM player)

2016-01-06 3
MarshallOfSound commented 8 years ago

I'm going to ping @amaitland again, there is definitely some strange DPI things going on here still

amaitland commented 8 years ago

. still tiny UI on my 4K (ignoring display 150% scale)

Can you clarify Tiny UI? Do you mean the Titlebar buttons?

And I think I will start up a beta stream, just looking at the best way to do it

GitHub allows you to tag a release as Pre-release. You may wish to consider having a Stable branch.

@MarshallOfSound Likely need some sort of diagnostic information/logging, get some more information about the hardware/environment. Can even be as simple as a key sequence that copies information to the clipboard so users can paste into their issue.

MarshallOfSound commented 8 years ago

@amaitland I think he is referring to the text inside CEF, if you look on the screenshot it is visibly much smaller than the example given in outlook.

And yeah, I'm tempted to move away from using github as a update platform though because it isn't the most user friendly platform for people who have never been to github before. I can messages all the time on reddit asking how to download because they can't find the release section :+1:

amaitland commented 8 years ago

@amaitland I think he is referring to the text inside CEF, if you look on the screenshot it is visibly much smaller than the example given in outlook.

A couple of point sizes smaller at most. Anyway, if it's supposed to be bigger then I guess that's a problem still.

@eturk1 Are you up for helping us out a little? If your up for it, I'd like you to download cefclient, it's a reference implementation of the Chromium Embedded Framework (CEF) for which powers the web browser. The exact version is important, so please pay attention.

capture

This will help us isolate the problem, if the result is consistent then likely upgrading to a newer version of CEF is requird.