search

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.28k stars 771 forks source link

Make lyrics available in app itself #197

Closed Meegooo closed 8 years ago

Meegooo commented 8 years ago

So, I looked into an API and apparently you have lyrics available for third-party apps, but i couldn't find any button that would show that lyrics in app itself. And that feature is not on the list (unless Ctrl+F failed me).

MarshallOfSound commented 8 years ago

So yeah, this is like a realllyyy long story but I'll shorten it for you.

TLDR: The lyrics part of the API was an afterthought and is completely unreliable. It doesn't work for any song newer than late 2015. Also I'm rubbish at UI design and couldn't come up with a nice way to show the lyrics.

TLDR2: If you / someone else wants to have a go at this by all means. I'd be interested to see what people come up with. :+1:

dqbd commented 8 years ago

I believe musixmatch has an API for developers (I think Shuttle uses it internally for lyrics).

MarshallOfSound commented 8 years ago

Haven't seen that before, I'll look into it if I get a chance

dqbd commented 8 years ago

Oh! Didn't read the TOS carefully. There is also the Genius API (should have a lot more than wikia).

KiitoX commented 8 years ago

So I have no real idea how to implement this but I think I have an idea for the UI... I think the lyrics could be displayed like another visualizer, so filling the whole screen, that would give them enough space and they're relatively easily accessible.

ghost commented 8 years ago

Could the lyrics possibly be overlayed when only showing the album art in fullscreen?

MarshallOfSound commented 8 years ago

I've looked into this and as far as I can tell my lyrics "thing" has about an 80% success rate with finding lyrics. This is probably too low too implement a solid lyrics feature

DavidHaruch commented 8 years ago

What if when the lyrics search fails, it just doesn't give the option to view the lyrics in the application, so if the lyrics are available, its good, but if not, nothing bad happens?

I think the best way would be to have a toggleable overlay over everything but the UI (button could be near the queue button or hidden in the radio/instant mix dropdown) that displays the lyrics (could also scroll based on time of the song).

If this is worth implementing I could give it a try, but it would probably take me a long time.

YodaEmbedding commented 8 years ago

I don't know if you've looked at this but this may or may not be helpful.