MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 767 forks source link

The Toolbar Icon has the wrong size. #2050

Open Nemo64 opened 7 years ago

Nemo64 commented 7 years ago

OS: Mac OS Sierra 10.12.2 (16C67) Google Play Music Desktop Player Version 4.0.5 (4.0.5)

Issue Descriptions: It somewhat bothers me that the toolbar icon is bigger than the others. It could be that this issue is only visible on a retina screen, but it's definitely outside the bounds of any other Icon there. Beside, it would be nice to disable the icon all together but that might be stuff for another issue.

bildschirmfoto 2016-12-26 um 19 38 28
a-gerhard commented 7 years ago

I'm having a similar issue with Ubuntu 16.10 (GPMDP v4.0.5) - it is slightly bigger than the others, but looks ugly and huge due to this. image

shadoll commented 7 years ago

Kubuntu 16.10 Google Play Music Desktop Player Version 4.0.5

The icon (at the top right) is not displayed correctly. screen_7

jostrander commented 7 years ago

@shadoll See #1350, it seems KDE doesn't do any kind of check to make sure the icon is within its bounds and won't resize it either. It's a logistical nightmare trying to provide icons in the correct size for every OS then DE. Not to mention catering to High DPI displays etc.

CorruptComputer commented 7 years ago

Same issue as @shadoll on Kubuntu 16.10, using version 4.2.0. image

jostrander commented 7 years ago

@CorruptComputer Refer to my previous comment about KDE, unfortunately it's not something we can easily do as each OS and DE handle icons differently.

CorruptComputer commented 7 years ago

@jostrander Look at an application like Steam, their icon appears correctly on every desktop and OS I have tried it on. So it is possible...

jostrander commented 7 years ago

Understandably. I won't deny any pull request that fixes this, but currently I don't have the time to spin up a vm for every variant and test the icons.

cawa-93 commented 7 years ago

I confirm the issue @shadoll

OS antergos 17.4 KDE plasma 5.9.5 Google Play Music Desktop Player: v 4.3.0

lesthack commented 7 years ago

Elementary OS Loki 0.4.1 Google Play Music Desktop Player: v 4.4.1

screenshot from 2017-10-26 13-59-10

Is really big, so, i changed the icon size for me: https://github.com/lesthack/Google-Play-Music-Desktop-Player-UNOFFICIAL-/commit/1c0759364a15c96d8e4c377f049cab48ba4228b5

screenshot from 2017-10-26 14-10-24

lucasjsoliveira commented 6 years ago

It looks a little big but really low-res for me on Arch Linux, KDE Plasma 5.14.0. Player version 4.6.1 icon

Gontran08 commented 6 years ago

Elementary OS Loki 0.4.1 Google Play Music Desktop Player: v 4.4.1

screenshot from 2017-10-26 13-59-10

Is really big, so, i changed the icon size for me: lesthack@1c07593

screenshot from 2017-10-26 14-10-24

Where can I find the icon to resize ?

lesthack commented 6 years ago

Elementary OS Loki 0.4.1 Google Play Music Desktop Player: v 4.4.1 screenshot from 2017-10-26 13-59-10 Is really big, so, i changed the icon size for me: lesthack@1c07593 screenshot from 2017-10-26 14-10-24

Where can I find the icon to resize ?

Check my branch: https://github.com/lesthack/Google-Play-Music-Desktop-Player-UNOFFICIAL-/commits/dev_tryicon

llays commented 5 years ago

GPMDP icon is also larger than the other round icons in the Dock. image To be honest, Google Chrome icon is also a bit larger than the others.

macOS Mojave 10.14.4 (18E226) GPMDP 4.6.1