MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 766 forks source link

Window: Full Size and Mini Player #2269

Open tempusfugit13 opened 7 years ago

tempusfugit13 commented 7 years ago

Hello. I got the following issues with the window on Ubuntu 16.04.2 LTS:

Mini Players is not mini:

captura de pantalla de 2017-02-27 18-25-26

And when I come back to the Full Size Player:

captura de pantalla de 2017-02-27 18-25-54

MarshallOfSound commented 7 years ago

This appears to be a window manager issue, you set the window to be fullscreen right?

tempusfugit13 commented 7 years ago

Yes. It works fine when I let the fullscreen window. The problem is when I want to set the mini player, I get the issue detailed in the first image. Then, when I want to come back to the fullscreen I get the issue detailed in the second image. After a few tries the fullscreen normalizes but I am not able to set the miniplayer. Not a big deal for me but I want to report it in case somebody has the same issue. Overall, it works really well and fluid. I need to install it on my Windows 10 and test it. And by the way, if you need a spanish translation for the app and add this language, I could help you if you want. :) Cheers and thanks for this great work.

DanielNautre commented 7 years ago

Hi, I have a similar issue on W10, after switching to the mini player and back and then switching to a different view (e.g. select a album), the content appears zoomed in. I've only noticed this since 2.4.0, though I wasn't using the mini player too much before.

Switcing to fullscreen and back several times did not help. Restarting the programm did not help with "Automatically load last viewed page on startup" on, but with option off, it helps.

gpmdp

Thanks for your great work.

jamdo63 commented 7 years ago

Same on Ubuntu 16.10. Miniplayer fills the entire screen and does the jitterbug. Music plays. This is a recent feature. Use your app every day... kudos.

Just realized "settings" does the same thing, without the jitter. settings 2017-03-13 21-00-09

jostrander commented 7 years ago

I don't have an Ubuntu machine to test on at the moment, seems like a zoom issue, which iirc was an issue with a particular electron release?

jamdo63 commented 7 years ago

Played with it more and it looks like the same problem DanielNautre is facing on W10. "Settings" is only zoomed if I was previously on miniplayer. Switching to full screen and back does not help. For me I have to click full screen after every change in view. Miniplayer is what starts the problem.

rgrauphics commented 7 years ago

I have the same issue running Linux Mint 18.1 - Issue happens whenever I want the use the mini player it scales automatically 100% in height and then all scaling of the elements are off. I have to shutdown and reboot the player to fix. music-player

Interesting - after posting this : Relaunched my player > Clicked the full screen button > clicked the mini player and mini player works! - If I click the mini player before full screen the scaling goes to 5000%. Or blownup.

Hopefully that helps find the bug in pressing the mini player without full screen engaged first.

FIX for Now: Rolled back to version 4.1.1 > https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/releases/tag/v4.1.1 **With this version I get random blank white screens and music stops - I don't think it is the player as I have had a few Chrome pages quit on me.

##################

Monitor Information - the issue happens on both monitors Samsung S27d590 - 1920x1080 - 96x96dpi (not sure if that is correct) Dell 2405FPW - 1920x1200 - 96x96dpi (not sure if that is correct)

##################

bioe007 commented 7 years ago

I am getting this behavior now too. Definitely a new feature.

On W10 if I switch to the mini player it actually starts 'growing' (the mini player window keeps getting bigger) and the contents zoom. from this -> image

to this -> image

Sometimes switching to normal mode again the UI is also way zoomed in and stays so until I kill the app and restart it.

(edit: forgot to add blown up normal ui) image

I'm using W10 and just updated to GPMD 4.20 tonight. Thanks

blacj commented 7 years ago

I have the above "growing" issue as well, on windows 7. I haven't had the "zoom" issue (if I'm understanding it correctly) however when I toggle out of the growing mini-player, the full size player is shrunk to the size the mini player last was. The above comment by bioe007 seems similar to mine.

jlink-home commented 7 years ago

I'm glad I'm not the only one with this issue. I ran into the growing mini player yesterday and now everytime I try to switch to the miniplayer it starts growing. I also have the 'Settings' zoomed in issue as well. Though I'm sorry I do not have anything truly constructive to add to the conversation.

MarshallOfSound commented 7 years ago

Everyone in this issue can you post your screen resolution, your screen DPI and exactly what screen this starts occurring on 👍

DanielNautre commented 7 years ago

Hi, This happens with a Dell 2009W resolution is 1680x1050. Not sure where to find the DPI

Alias44 commented 7 years ago

Ive got it on my laptop: HP Pavilion 15-ab000, resolution is 1920x1080 at 125% scale, 141.21 PPI.

Edit: Running Windows 10

DPI/PPI isn't listed in Windows (that I know of, but I could always be wrong), I used this site to calculate mine: https://www.sven.de/dpi/

bioe007 commented 7 years ago

This happens for me on two systems:

  1. Laptop - Windows 10, local display is native 3840x2160: scale = 150% External monitors are both 1920x1080, no scaling

  2. Dekstop - Windows 10, Monitor 1: 3840x2160 - scaling = 150% Monitor 2: 2560x1440 - scaling = 125%

I can't find the actual DPI value in Windows anywhere, only the scaling UI in the settings menu.

also, I've got a new quirk for this issue. Using my Laptop and going from laptop display only to external monitors gave me the opposite problem, where everything in the UI got tiny: gmpd_tiny

Album art still scaled correctly: gmpd_tiny2

and the mini player worked fine (no 'growing' problem): gmpd_tiny_mini_ok

I put it back into normal->mini mode a few times and it worked again until I resized the window. Toggling again a few times and it seems to have fixed it more permanently.

Hope that helps.

blacj commented 7 years ago

The scaling never occurred to me - I set it back to 100% and the mini player no longer grows. Hope that helps.

Edit: So, now that I changed the scaling to 100%, it isn't growing anymore. However if I shrink or stretch the mini player to my liking, once I toggle back to the full player, all of the UI is scaled relative to how much I shrank or stretched the mini player. If I make the mini player tiny, all the text is tiny when I go back to full. If I make it HUGE, the UI is so blown out it cannot be used, and I have to shut down and reopen the player entirely.

moymike commented 7 years ago

Okay, I had the same "growing" behavior, and was able to figure out how to stop it. I am running Google Play Music Desktop Player 4.3.0 on Window 10 Version 1703 build 15063.250

The "fix" for me was to turn off "Use system window borders" under the General Tab. (right click the GPMDP system tray icon, select "Desktop Settings")

After turning that setting, right click the system tray program and "Exit" and reload. By switching the setting on and off, I am able to duplicate the "growing" behavior.

Enjoying the music and the GPMDP UI once again!! Thanks for all your work on the program.

bioe007 commented 7 years ago

Well, I've never set the 'Use system borders option" but I figured I would try anyway.

Toggling this makes no difference here.

I'm now on GPMD 4.3.0 and actually the UI is getting worse, now even the UI is chronically mis-shaped and so the mini-player button doesn't show unless I full-screen GPMD.

moymike commented 7 years ago

Before you toggled it it, was it set on? I had to toggle it off, then completely shut GPMD down before it worked correctly again. I actually toggled everything off except for "minmize to tray" under general, and "always on top" under mini player. Then I close the app and "Exit" the systray app. Once closed, I reopened it, checked the settings to make sure all the toggles are off, and launch and test the mini player. Problem is gone.

bioe007 commented 7 years ago

No, it has never been turned on. Exactly what I tried:

  1. Open settings
  2. Turn on 'Use system borders'
  3. quit & restart GPMD
  4. Open settings, turn off 'Use sys borders'
  5. quit & restart GPMD
  6. growing mini-player still happens, ui slightly more jacked up than ever
DanielNautre commented 7 years ago

No luck for me trying to switch system borders on & off. I've tried reducing the size of the mini player so that the UI doesn't seem scaled up compared to the standard interface, that does resolve the problem. I haven't experienced the growing mini-player symptom for now.

fahimalizain commented 7 years ago

This issue is observed when the mini-player is resized from its original size. When we restart the application, the scaling is fine. Open the mini player and if its large compared to the original mini player size, the main window is zoomed in. Fix is to restart the player, goto the mini player and resize it to a small window. Im running Win10, 1080p. Same here, no growing mini-player issue. Great work by the way :)

mquevill commented 7 years ago

Whenever I switch to the mini-player, it tries to go to full height of my monitor, but then needs to rescale to square, but then the height is too large. This behavior keeps causing the mini-player's size to change until I make it small enough. It is defaulting the mini-player to open in fullscreen, which cannot be square.

I also occasionally encounter the super-large interface when I switch back to the regular interface. Toggling the system borders hasn't helped either of these issues.

[Linux Mint 18.1 with Cinnamon 3.2.7 on 2 1680x1050 monitors]

JnthnWnbrg commented 7 years ago

Same on Mac OSX El Capitan. Neither checking nor unchecking System Borders and restarting the application has helped.

ghost commented 7 years ago

I'm having the same issue with the mini player growing and then the main window zoomed in. However, for me this only happens if I move the mini player to a different monitor than it was started on. If I move it back to the monitor that I started it on, the growing stops and returning to the main window results in the normal view.

Windows 10 (Creator's Update) Laptop Native Monitor 1920x1080 scaling=125% Additional Monitor 3840x2160 scaling=150%

Great app!

MarshallOfSound commented 7 years ago

@IrksomeZeus Which monitor does it grow on, or is it just always the one it didn't start on?

ghost commented 7 years ago

@MarshallOfSound Whichever it doesn't start on.

davidcp94 commented 7 years ago

I have a similar issue in Win10 with opening the mini player causing ui elements to resize, but it happens regardless of in which screen the main player is launched or the mini player opens. I have included a video of the behavior: video

Monitor shown in video: 1600900, 100% scaling. Second monitor (not shown, but experiences identical issue): 19201080, 150% scaling.

jamdo63 commented 7 years ago

4.3.0 works fine on Win 7 at work. All sorts of scaling problems in basic app and in miniplayer (worst there) on Ubuntu Gnome 17.04 at home.

alutman commented 7 years ago

I have a similar issue under Win 7 with 4.3.0.

Here's a GIF

StockForStudentLoans commented 7 years ago

moymike!!! Your answer solved the growing issue for me! I thought that I had tried that before, but on this go it confirmed work. Bravo!

jamdo63 commented 7 years ago

Nice work around Alutman

jvl59 commented 7 years ago

Running the latest version 4.4.0 and the scaling issue is happening on my system also.

Windows 10 Home build 1563

I tried the Windows border work-around and it didn't work.

bbisinger commented 7 years ago

I'm actually having the reverse problem. I'm not sure what triggers it, but suddenly the app is very zoomed out -- I can barely read anything the font is so small. The mini-player button also seems to disappear ... or I just kind find it because it's so tiny.

Win 10 Monitor 1 - 1920 x 1080 Monitor 2 - 1920 x 1200

fredphoesh commented 7 years ago

I find to fix it, pressing CTRL-minus or CTRL-+ works fine to scale back to normal.

SourceCode commented 7 years ago

This is occurring for me as well with the latest build, cntrl - and cntrl + do not work on mac. The UI gets broken and can not be resolved without a restart. The player once in this state, loses its scale and mind about it's scale of its UI.

The primary cause of this is if you have had the mini player resized and go from the fullscreen player to the mini player then back. The UI will scale to the size of the mini players window and then once returning to the primary window it does not scale back. I was able to jack around a bit with getting the controls back in place by double / triple clicking the applications OS bar. (whatever that is called lol).

southrop commented 7 years ago

Hello. I'm getting the growing issue in the mini player with 4.4.1. Ctrl+0 works to reset the zoom on the interface, but because the mini player resizes right away, the interface zooms up again. When going back to the regular player, Ctrl+0 works to reset the zoom but I still need to manually resize the full player. I'm not using the full player in full screen.

My system is Windows 10 with a 2160x1440 monitor and 125% scaling on it.

MudkipMao commented 7 years ago

Hi, I just wanted to let you know that I am also having the issue where the Mini Player is slowly growing. My build is Windows 10 Home, Version 1709, OS Build 16299.19. My display is 3840x2160 and I'm using 200% scaling. Also I noticed when the Mini Player is growing, my laptop runs REALLY hot!

jamdo63 commented 7 years ago

Had the mini player problem on Ubuntu Gnome 17.04 but it appears to have resolved when I upgraded to 17.10 even though I did not do a fresh install. That was a surprise.

sevku commented 7 years ago

Same issue on Ubuntu 16.04 LTS

bitglue commented 6 years ago

This also seems to happen on Ubuntu, Awesome window manager, on a 4k monitor with gnome scaling factor set to 2 (gsettings set org.gnome.desktop.interface scaling-factor 2)

Also have some xrandr configuration to accommodate rotated monitors of different dpi: xrandr --output HDMI-0 --mode 1920x1080 --pos 0x0 --scale 1.5x1.5 --rotate left --output DP-1 --primary --mode 3840x2160 --pos 1620x360 --output DVI-I-1 --mode 1920x1080 --pos 5460x0 --scale 1.5x1.5 --rotate right --dpi 144

smokelore commented 6 years ago

I had the same issues discussed above on Windows 10. When switching to Mini player the Mini player window begins to grow slowly in the direction of the bottom-right corner.

Monitors:

And whenever I switched back away from the Mini player, the scaling on the main window's scaling would be way off. Could basically only see the top two buttons of the sidebar filling the whole window.

@moymike 's suggestion of turning off "Use System Window Borders" fixed it. Very grateful for that. But just adding another data point to this issue because I'd like to be able to use that setting in the future.

Thanks for all your hard work y'all!

jvl59 commented 6 years ago

I found a work-around for this on Windows 10.

I'm using version 4.5 of the music player.

  1. Right click the desktop icon and select properties.
  2. Select the compatibility tab.
  3. Select "Override high DPI scaling behavior" and "Scaling performed by: System (Enhanced).

The only set back is that fonts are slightly blurry, but they are still readable. Hopefully this gets fixed soon.

This has worked for me so far.

Nephiel commented 6 years ago

Also experiencing this on Linux with 4.5.0. If I have the full size player window maximized when I click on the icon on the lower right to switch to the mini player, then the mini player window starts maximized in width and immediately enlarges in height to keep aspect ratio. On a common laptop screen this results in the lower third of the mini player window being drawn off the screen.

azxcqer commented 6 years ago

A few more information and maybe a few workarounds.

Running GPMDP 4.5.0 on Ubuntu 17.10 with KDE (it's actually kubuntu) and using 2 monitors at 1366x768 and 1280x1024.

The bug happens when the window is forced to keep a size. The default behavior of the mini-player seems to try to resize itself to always keep a 1:1 (or near) ratio. When you click the mini-player buttom and the window is maximized, tiled (when I'm using quicktile on KDE) or something similar, it will fail and either jitter trying to resize or just assume the new resizing without being able to resize the window and thus everything will be too big.

The workaround I'm using at the moment is just not tilling/maximizing the window. Resizing it by hand when I need to and it works as intended. It's not ideal but this app is too good to stop using over this.

Some observations that may help people with this problem:

jmiskinis commented 6 years ago

I can confirm that it's an issue. Using GPMDP 4.6.1 on Arch Linux with GNOME Shell 3.30.1 @ 3840x2160 (scaling - 200%, 282 ppi according to http://dpi.lv). Plenty of jittering and redrawing. Here's a short video:

https://gfycat.com/EnchantedDimElkhound

Other than that, thanks for a very useful and nice implementation of GPMP :)