search

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 767 forks source link

Support nonstandard keys #2556

Closed lf- closed 7 years ago

lf- commented 7 years ago

OS: Windows 10 1703 (build 15063.296)

Issue Descriptions: Unusual keys such as F13, F14 and F15 are unsupported in GPMDP. I'm generating these keycodes with an arduino based macro keypad and would like to bind them as like/dislike without interfering with any other things on the machine.

Steps to Reproduce: Produce F13/F14/F15 scancodes and try to bind them as things in the settings.

Note: I've tested these with this thing and they definitely are appearing.

MarshallOfSound commented 7 years ago

Should be an easy PR @lf- 😄 😉

https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/blob/master/src/renderer/ui/utils/constants.js#L18

Currently we hardcode F1-12 in a range call. I'm not sure if F13,14,15 are legit keycodes or not but if you can show that they are, change that range value and test it to make sure it works on your machine I'd accept that PR.

lf- commented 7 years ago

I tested with a chrome key tester thing and it works. Need to get node dev environment working on windows (ew).