MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 766 forks source link

Desktop Settings Do Not Save #2752

Closed compeek closed 7 years ago

compeek commented 7 years ago

OS: Windows 10 Pro x64

Issue Descriptions:

None of the the Desktop Settings save anymore. I change them and close the window and open it again and they are reverted. I don't see a button to manually save them anywhere, so it seems impossible to save them.

I noticed this after updating to 4.1.1, but I haven't tried changing the Desktop Settings in a while, so maybe it was broken before 4.1.1.

I uninstalled and deleted the folder in my AppData/Roaming and installed again, and it still doesn't work.

I could not find any other reports of this, but it happens for me on multiple computers.

Steps to Reproduce:

1) Install GPMDP. 2) Open Desktop Settings and uncheck Minimize to Tray. 3) Close settings window and reopen. 4) Observe that the checkbox is checked again. 5) Uncheck it and close the app. 6) Observe that you get a warning and it still minimizes it.

welcome[bot] commented 7 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

MarshallOfSound commented 7 years ago

Can you post the debug zip file?

https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ#how-do-i-generate-this-debug-zip-file

Observe that you get a warning and it still minimizes it.

When this warning appears can you click "Don't tell me again" and then click close again, tell me if the warning appears 👍

compeek commented 7 years ago

Here is the debug zip:

debug_info.zip

If I go an uncheck the "Minimize to Tray" option and then click close, I get the warning. I click "Don't tell me again" and it does indeed close (it does not minimize to tray). If I open it again and click close first thing, I still get the warning, and it does not close (it does minimize to tray).

I noticed that other settings do seem to take affect immediately when I change them, but if I restart the app, they are reverted.

So it seems like it's saving them in memory, but not persisting them to the config file or wherever they are stored.

And if I reopen the Desktop Settings window after changing some things and closing it while the app is still running, the settings appear to be reverted immediately, even though the changes I made are in effect until I close the app.

For example, if I enable "Show track progress in the taskbar" while a song is playing, I see the progress in the taskbar immediately. If I reopen Desktop Settings, the box is unchecked again, but I still have progress in the taskbar. If I restart the app, I no longer have track progress in the taskbar.

naaronne commented 7 years ago

Noticed the same issue on my recent upgrade.

MarshallOfSound commented 7 years ago

Automatically closed as tagged Awaiting Response

compeek commented 7 years ago

@MarshallOfSound Can we keep this open? It's an outstanding issue that affects multiple computers for me, and at least one other person has said they see it as well.