search

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 766 forks source link

No TouchBar Support in High Sierra #2782

Closed ghost closed 7 years ago

ghost commented 7 years ago

Running MacOS High Sierra currently, public download. I have lost the playing music toggle with the playhead and pause, play, skip icons etc.

To replicate:

welcome[bot] commented 7 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

MarshallOfSound commented 7 years ago

@Colecperrine I haven't updated my mac to High Sierra yet so I can't debug this for a while. (I normally wait at least a month after public release for things to stabilize)

MarshallOfSound commented 7 years ago

Just tested this on a friends macbook with High Sierra and the touch bar stuff works fine. I'd suggest giving your mac a quick reboot to see if that fixes it.

parkerbxyz commented 7 years ago

I am having the same problem with version 4.4.1 running on macOS High Sierra 10.13. Rebooting does not fix the issue. I also tried uninstalling and reinstalling the app, but that didn't help either.

ghost commented 7 years ago

Same here, I got it to work for a few minutes but it went away immediately. The "Now Playing" item in notification center works for play, pause, and skip, but it doesn't show a timestamp and also says "undefined" for any metadata. Rebooting doesn't help.

ghost commented 7 years ago

Update: The issue doesn't appear to happen on 10.13.1, it may have just been an error with 10.13.0 on the Macbook 13", any similar results from anyone else?

parkerbxyz commented 7 years ago

It's still not working for me on 10.13.1, unfortunately. Here's how my Touch Bar looks when the app is open and playing music: image

Touch Bar support is working fine in other apps, such as Google Chrome. Here's how my Touch Bar looks when Google Chrome is open and active/focused: image

ghost commented 7 years ago

Lost it again, seems to only work on the first try after rebooting.

parkerbxyz commented 7 years ago

When I play music in the app and open Notification Center, the Now Playing widget says "Undefined" as seen in this screenshot: gpmdp_screenshot image

I suspect the touch bar issue is a side effect of a bug in the Now Playing feature. Should I create a new issue for this @MarshallOfSound?

UPDATE: Rebooting my computer fixed the "Now Playing" issue--at least temporarily. When Now Playing is working, this Now Playing icon shows up on the touch bar: image

Here's how it looks when you expand it: image

So this appears to be working when a different app is focused, but not when the music app itself is focused. Is this expected behavior?

For comparison, here's how the touch bar looks when iTunes is open and focused: image Here's how it looks when iTunes is open, focused, and playing music: image

Here's how it looks when playing music in the Google Play Music Desktop Player while it is focused: image

tehdef commented 6 years ago

Not trying to re-open a semi-oldish issue here, but I have a comment on this. Unfocused, seems to be working fine. Focused, it has no controls on the touch bar. I can use spacebar and arrow keys, but maybe it would be nice to have that bar present when the app is focused?

Thanks!