MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 767 forks source link

Add adblocking functionality to GMPDP #2941

Closed devksingh4 closed 6 years ago

devksingh4 commented 6 years ago

Hi, Request for feature exactly as above (don't know how to add enhancement tag), to stop the ads for free users when starting a radio or that pop up once in a while. Don't exactly know enough JS to be dangerous, but I am willing to take a crack at it.

Thanks.

welcome[bot] commented 6 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

jostrander commented 6 years ago

I believe this is something we've decided previously against implementing in the app. Trying to stay as far out of the grey area as possible. You can implement ad blocking at the network level or by using adblocking dns as an alternative solution.

tabedzki commented 6 years ago

Hi @jostrander, I did a quick search for ad blocking software in the issues and I couldn't find a reason against the implementation elsewhere aside from API differences. Is there a way to build a feature that would allow the end user to integrate the ad-blocker (such as u-origin) after you guys provided the software so that way you guys can stay out of that gray zone? Thanks in advance.