MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 766 forks source link

Implement Lyrics search using "Vagalume" API #2984

Open victorfontes opened 6 years ago

victorfontes commented 6 years ago

Vagalume is a brazilian lyrics site that offers a free api (https://api.vagalume.com.br/docs/letras/).

I've implemented a source for this api and I've been using in my local build for a while and the results are awesome. The api is fast and their database is huge.

I would like to know if I can submit a pull request with this feature.

welcome[bot] commented 6 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

jostrander commented 6 years ago

Do they only have translated lyrics or does it do english lyrics as well?

victorfontes commented 6 years ago

It has english (and other languages) lyrics as well, they have translations but its a separated part of the api.

MaverickMartyn commented 6 years ago

Hey there. Related to this, I am currently fiddling with bringing MusixMatch support here as well.

jostrander commented 6 years ago

@MaverickMartyn I wouldn't bother. https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/What-happened-with-3.2.5%3F

MaverickMartyn commented 6 years ago

Ah. I see. Welp. I already made my own player over at https://www.github.com/MaverickMartyn/youtube-music-desktop It has support for MusixMatch lyrics, although I am not crawling. I am using the same API as their Chrome extension for YouTube videos. I guess I'll leave it up and see if they contact me.

azumukupoe commented 4 years ago

Will this simple script not work for this issue? I think it'll be easier than implementing an API https://qiita.com/sutoh/items/3a4d54610388bcad14d0