Open Rasive opened 6 years ago
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.
The .desktop
file in ./vendor/snap
is the one that's going to be copied to /usr/share/applications
and is the one you should change in the repository.
@SolarLiner Only for snap builds, the .deb
builds don't use that file
Which file is used for deb builds? Searching through the repository on GitHub only revealed one .desktop
file, and it's the snap one.
It's generated if I'm not mistaken.
So we use 'electron-installer-debian' which generates the desktop file here:
https://github.com/unindented/electron-installer-debian/blob/master/resources/desktop.ejs
Is there a way to use a static file or a custom template? Because that would allow the deb file to include the PulseAudio media role workaround #2684 #2685 and localize the desktop file, like I did for French in the snap version.
@SolarLiner I'm pretty sure their's a config option to provide a custom base ejs
template for the desktop file 👍
@MarshallOfSound You are correct:
https://github.com/unindented/electron-installer-debian/#optionsdesktoptemplate
Would a static file be okay? The default has conditional rendering but I don't think the name is going to change really... :stuck_out_tongue:
In which case, I think it'd avoid duplication to use the same file for the snap and deb/rpm packages.
I mean, it makes sense to me to only have one desktop file for everything.
Has this been changed? Because the deb file for the 4.6.1 release still doesn't seem to use the .desktop file that the snap build uses.
Hello
I made a desktop entry and added the dbus commands to get this effect:![preview](https://user-images.githubusercontent.com/1022792/39467000-103a29d8-4d2c-11e8-8c3f-202d90343f04.png)
I am not sure however where I should contribute the .desktop file. I seems you have one in vendor/snap but I am not sure if this would be the right place