search

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.28k stars 767 forks source link

Last.fm Scrobbling Broken for YT Music #3174

Open Izumemori opened 6 years ago

Izumemori commented 6 years ago

OS: Arch Linux

GPMDP Version: Built from https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/commit/82c84871163e0949172e6dde7550f6844fb88749

Issue Descriptions: Last.fm scrobbling seems to be broken, which is probably to be expected as the YT Music integration is still in alpha, just wanna give a heads up that this is an issue. Scrobbling works fine in GPM mode.

The issue seems to be that the change:track event doesn't include a duration. I've fixed this locally by waiting a few seconds before sending the nowplaying and pulling the time from the PlaybackApi instead.

Steps to Reproduce: Switch to YT Music while having Last.fm authorized and play any song.

debug_info.zip

welcome[bot] commented 6 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

joshlebed commented 5 years ago

@Izumemori do you think you could detail how you fixed the issue locally? I'd like to do the same but I'm not quite sure how. Thanks!

lelukas commented 5 years ago

yea, me too. describe it, please.

festivefirstname commented 5 years ago

Yes, please describe how to fix! I've had to stop using it for YTM in the meantime.

bellini666 commented 5 years ago

@Izumemori I'm also interested in knowing how did you workaround the issue

mpgarate commented 5 years ago

@Izumemori I am also interested in the local workaround. I tried to debug locally and have not been able to resolve.

mpgarate commented 5 years ago

I submitted this pull request with a proposed solution: https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/pull/3476

mpgarate commented 5 years ago

@MarshallOfSound please let me know if there's anything further you recommend on the above PR.

lelukas commented 5 years ago

so? did the commit pass?

mpgarate commented 5 years ago

We are waiting for a code review and merge from the maintainer.

rcp87 commented 5 years ago

Same problem with YouTube music here... Not scrobbling anything to lastfm. Google play backend works well, last stable version 4.6.1

lelukas commented 5 years ago

any news, guys?

nayTuHbl4 commented 5 years ago

this is a problem because of which I do not use the program

TiraelSedai commented 4 years ago

@MarshallOfSound have you had a chance to look at @mpgarate 's PR?

dukhevych commented 4 years ago

Want to start migrating my library to YT Music, but lack of lastfm scrobbling feature for YT Music is what stops me. Need this.

festivefirstname commented 4 years ago

https://ytmdesktop.app/ has working last.fm intergration for anyone interested. And is just solid all around.

I've been using the official PWA for YTM with web scrobbler with good results for a while too. Bummer GPMDP's YTM integration isn't working.

juliovedovatto commented 4 years ago

Well it seems we can consider this project kinda "dead". Since author didn't make any considerable commits since last year, nor have accepted PRs.

Also: https://www.usatoday.com/story/tech/2020/05/12/google-play-music-shut-down-how-transfer-tunes-youtube-music/3112297001/

Thanks for the tip @restinginlove, your recommendation worked really well with YT Music and Last.fm 👏🏻

@MarshallOfSound thanks for you efforts for such great player, I used over the years. But I think it is time to me to move on, since GPM will be killed soon.