MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 767 forks source link

Debian package dependency doesn't garuantee working avahi solution #3265

Open z0rc opened 6 years ago

z0rc commented 6 years ago

Checklist:

OS: Kubuntu 18.04

GPMDP Version: 4.6.1

Issue Descriptions: Avahi isn't usable despite avahi-daemon dependency

Steps to Reproduce: Install GPMPD on fresh Ubuntu, start via console, observe:

error: Failed to load bonjour with error: {}
Bonjour is required to use Chromecast Support or to enable ZeroConf for the PlaybackAPI
On linux you need to install "avahi"

Basically GPMDP requires old compatibility layer to be present, as it doesn't use native Avahi API. In order to properly enable avahi support user has to install libavahi-compat-libdnssd1.

So, I believe the proper fix will be adding mentioned package to dependency list.

Also while we're at it, again I'm asking to reconsider decision about making avahi-daemon as hard dependency and downgrade it to Recommends. Per Debian Policy:

Recommends

This declares a strong, but not absolute, dependency.

The Recommends field should list packages that would be found together with this one in all but unusual installations.

Avahi/Chromecast case fits perfectly into this definition.

frankbaele commented 6 years ago

Same problem on fedora 27, had to install the following package avahi-compat-libdns_sd to make it work .

kkavchakHT commented 5 years ago

I also had to install libavahi-compat-libdnssd1 on Kubuntu 18.10