Disliking a song breaks YT Music UI

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music

https://www.googleplaymusicdesktopplayer.com

MIT License

8.27k stars 766 forks source link

Disliking a song breaks YT Music UI #3424

Open ajmeese7 opened 5 years ago

ajmeese7 commented 5 years ago

Checklist:

[ X] I have checked that there are no issues with similar or the same content
[X ] I have checked the FAQ (https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ) and the answer I am looking for is not there
[ X] I have double checked and can reproduce the issue

debug_info.zip

OS: Windows 10

GPMDP Version: 4.6.1

Issue Descriptions: Every time I dislike a song (with the YouTube Music player) it starts skipping every single song on the entire playlist and crashes the entire UI.

Steps to Reproduce: Switch to YouTube Music, select a song (it will open an automatic playlist), and dislike the song. It has happened to me 7 times in a row now.

welcome[bot] commented 5 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

jostrander commented 5 years ago

Do you have "automatically skip disliked songs" enabled in GPMDP settings?

ajmeese7 commented 5 years ago

@jostrander I did have that enabled, but all the songs that it was skipping were songs that I had never heard before and hadn't disliked yet.

EDIT: When I disabled that option, the issue was resolved, but that doesn't change the problem. Whenever I disliked a song with that option enabled, it skipped every song on the playlist rather than just songs that I disliked.

jostrander commented 5 years ago

Since we are essentially UI scraping, the dislike icon is probably delayed to update behind the track change notification we get. That causes it to skip the song, because the logic is ran on track change. Should be a somewhat easy fix, we just need to adapt the ytm.js for it.

jostrander commented 5 years ago

I think this may be partially fixed with an upstream track change listener update.

duckwagon commented 5 years ago

Problem still exists, on mac as well.