MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 766 forks source link

Google Sign In may break in June 2019 #3545

Closed MarshallOfSound closed 4 years ago

MarshallOfSound commented 5 years ago

Just raising this pre-emptively as a tracking issue for https://github.com/electron/electron/issues/17887

Unclear if whatever measures Google implement will affect Electron or if we can work around them locally. If it's just UA sniffing we can defeat that easily, I guess we'll just have to wait and see what happens.

apt-itude commented 5 years ago

I'm not sure if this is still being tracked, but as of the last few days, I can no longer use the app. It gets stuck at "Loading Music Library" indefinitely. This issue jumped out at me given the timing.

sulymkaa commented 5 years ago

have the same issue, cant use desktop app on mac os, please fix asap

MarshallOfSound commented 5 years ago

It gets stuck at "Loading Music Library" indefinitely.

This was actually caused by an unrelated GPM incident. I hit it yesterday on one of my machines, deleting your cache and relaunching will fix it.

jfries289 commented 5 years ago

@MarshallOfSound I'm experiencing the same issue (OSX). I deleted the cache located at ~/Library/Caches/google-play-music-desktop-player, but the issue persists. Is there something else I should remove?

Darktex commented 5 years ago

This started happening to me too! I also deleted my cache at ~/Library/Caches/google-play-music-desktop-player to no avail :(

cscuderi commented 5 years ago

Chiming in. The issue also happened to me on OS X. Stuck at "Loading music library" :(

cscuderi commented 5 years ago

I deleted the cache folder at: /Users/carlinscuderi/Library/Application Support/Google Play Music Desktop Player/Cache, restarted the application, and it now works.

Darktex commented 5 years ago

I haven't literally done anything but it started working on its own lol

ervinb commented 5 years ago

I'm having issues signing in on W10.

Capture

noizyboy commented 5 years ago

Same issue here as @ervinb.

signin

MarshallOfSound commented 5 years ago

I just took the risk and signed out and signed in again, worked fine for me (even switched networks in the middle).

I think y'all are getting hit with an unfortunate A/B test. My best suggestion is to try one of the builds from master and see if it helps

clingsmash commented 5 years ago

I'm having the same issue. I have tried releases from the 4.7 minor all the way back through master 4.50. I have signed in previously using this account on an old computer, but have not been able to successfully get past the login on W10

image

MarshallOfSound commented 5 years ago

@clingsmash Where does that "Learn more" link take you?

noizyboy commented 5 years ago

The learn more link takes you here: https://support.google.com/accounts/answer/7675428

benpetermorris commented 5 years ago

I am also experiencing the "Couldn't sign you in" issue on a new install on W10 -- exactly the same result as @noizyboy's screenshot above. I installed and signed in successfully on another device a month or two ago, and I've been using the software for about a year without any other problems. (Great app, by the way!)

GHubNH commented 5 years ago

Same here in Win10. "Couldn't sign you in" in 4.7 minor, 4.6.1 and in 4.5.0. 4.7 has a dialogue as shown in clingsmash. 4.6.1 and 4.5.0 display the slightly different dialogue in the 2 screen grabs above that.

jimmoua commented 5 years ago

Getting the exact same sign-in issue on GNU/Linux...

paulgittings commented 5 years ago

"Couldn't sign you in" on Windows 7, new install, haven't used before.

clingsmash commented 5 years ago

I have a w7 and w 10 device if you need any testing done.

craigrouse commented 5 years ago

Same issue for me.

Deckee commented 5 years ago

I have hit the same issue, the OS is Debian 5 stretch. just get the "couldn't sign in" page after trying to sign in. on a fresh install. gpmdp is v4.6.1

genocidalrobot commented 5 years ago

also getting the "Couldn't Sign In" page on 4.6.1 in W10

DennisTerrell commented 5 years ago

Also experiencing the "Couldn't sign you in" issue on v4.6.1.

Mushy-Snugglebites-badonkadonk commented 5 years ago

Verified issue on macOS

You are trying to sign in from a browser or app that doesn't allow us to keep your account secure. Try using a different browser.

LordPantaloons commented 5 years ago

Just got this problem too, changed my password and got booted after a bit like I expected. tried to log in with new password and get this screen, using most recent version, windows 10. Curiously it lets me sign in with a different account but not the one I normally use. Ive changed passwords before and not had this problem. ss+(2019-08-26+at+03 53 30)

MarshallOfSound commented 5 years ago

I've tried a few accounts and haven't seen this yet, I think Google is A/B testing this stuff. Not sure what else I can do without a way to repro this on my machine and try find a way around it

LordPantaloons commented 5 years ago

have you tried changing the password while signed in, letting it boot you and trying to sign in with the new password?

ervinb commented 5 years ago

@MarshallOfSound I was able to avoid that error after spoofing the user agent, by changing https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/blob/69150941ca38e64d077c21a3fcdad8049efe7858/src/index.js#L110 to

mainWindow.webContents.session.setUserAgent('Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:58.0) Gecko/20100101 Firefox/58.0');
MarshallOfSound commented 5 years ago

@ervinb I'd take a PR for that 👍 . I'd prefer for it to be dynamic and only remove the bits that Google is sniffing out, but for now that's a solid hack 👍 We don't use the UA for anything so we can set it to whatever we want 😄

arjun-prs commented 5 years ago

please tell how to install the app again after implementing this change!!!!

@MarshallOfSound I was able to avoid that error after spoofing the user agent, by changing

https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/blob/69150941ca38e64d077c21a3fcdad8049efe7858/src/index.js#L110

to

mainWindow.webContents.session.setUserAgent('Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:58.0) Gecko/20100101 Firefox/58.0');
ervinb commented 5 years ago

@arjun-prs Environment:

$ node --version
v10.16.3
$ npm --version
6.9.0

Run with (like described in the readme):

# clone the repo
$ git clone https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-
$ cd Google-Play-Music-Desktop-Player-UNOFFICIAL-

# install dependencies
$ npm i

# build and start the app
$ npm run build && npm start
LordPantaloons commented 5 years ago

so is there going to be an update to fix this or is the reference above going to be the only fix? I dont code or know what any of this means I just came here to try to figure out what the deal is so I dont have to use the browser player.

Mushy-Snugglebites-badonkadonk commented 5 years ago

so is there going to be an update to fix this or is the reference above going to be the only fix? I dont code or know what any of this means I just came here to try to figure out what the deal is so I dont have to use the browser player.

Scrolling to the top of this issue shows that @ervinb submitted a pull request with a proposed fix in #3608 so, now we wait for it to be peer reviewed before possibly being merged.

You might want to hit the "Watch" button and/or "Star" button on this repo to be notified of future developments and fixes.

I'm right there with you @LordPantaloons, I want my keyboard media keys support back without having to use Chrome and this app is the answer. #FirefoxForLife

Switchmans commented 5 years ago

image September 2, all attempts to enter do not work, help!

sigma67 commented 5 years ago

Download the latest build from Appveyor and install to fix the issue: https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/branch/master/artifacts

Switchmans commented 5 years ago

Download the latest build from Appveyor and install to fix the issue: https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/branch/master/artifacts

Thanks is works!

LordPantaloons commented 5 years ago

Awesome, worked like a charm. I didnt realize how much I used this app until I couldnt.

aokegbile commented 5 years ago

@LordPantaloons Might as well start coding and joint the party :D

eturk1 commented 5 years ago

brilliant @Switchmans ! Download worked perfectly on Win10 x64 1903

Mushy-Snugglebites-badonkadonk commented 5 years ago

Download the latest build from Appveyor and install to fix the issue: https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/branch/master/artifacts

I'm sorry, but I cannot trust a cross-site posted link; call me skeptical. I appreciate that you're compiling the source code and sharing it, but how do we know it's legit? I'll wait for the "official" release here on this repo.

@LordPantaloons Did you get any ransomware yet?

MarshallOfSound commented 5 years ago

@Mushy-Snugglebites-badonkadonk That link comes directly from this projects automated CI builds. They were built and code-signed by my certificate. You can consider them safe

LordPantaloons commented 5 years ago

Download the latest build from Appveyor and install to fix the issue: https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/branch/master/artifacts

I'm sorry, but I cannot trust a cross-site posted link; call me skeptical. I appreciate that you're compiling the source code and sharing it, but how do we know it's legit? I'll wait for the "official" release here on this repo.

@LordPantaloons Did you get any ransomware yet?

its good my dude

craigrouse commented 5 years ago

Would anyone be so kind as to do a build for macOS? I've tried building on my machine, but getting a few npm-related errors. I would be eternally grateful 🙏

alanjferguson commented 5 years ago

@craigrouse I've got build working on macOS although theres a couple of extra steps I had to do to get past the errors (happy to be corrected if these are the right steps as I'm not an expert with Node);

If you've installed node via brew then it will be v12 but build only works in v11 so you can install nvm which will let you manage having multiple node versions installed together.

curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.34.0/install.sh | bash

Then install and use v11

nvm install 11 && nvm use 11

From this point build should work as normal (might need to clean your git clone with git clean -dxf or just reclone the repo)

npm install && npm run make:darwin

craigrouse commented 5 years ago

Thanks for spending time on this @alanferguson. I'll give it a go!

Mushy-Snugglebites-badonkadonk commented 5 years ago

Download the latest build from Appveyor and install to fix the issue: https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/branch/master/artifacts

I didn't upgrade the app or anything, but today I was able to sign in and start using the application. Hurray! (Although, now I am curious as to how it is working now.)

paulgittings commented 5 years ago

I also haven't upgraded but was able to log in this morning!
Chrome on Windows 7

craigrouse commented 5 years ago

Works here too!

Stanzilla commented 5 years ago

Latest Appveyor build with the useragent change sadly fails

m52go commented 4 years ago

Yeah I'm getting this error now in 4.6.1 on Ubuntu...