MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 766 forks source link

Mini player enlarges #3567

Open Fainirael opened 5 years ago

Fainirael commented 5 years ago

Checklist:

OS: Windows GPMDP Version: 4.6.1 Issue Descriptions: Mini player enlarges when dragged on screen Steps to Reproduce:

  1. Switch to mini player
  2. Drag and arop it around the screen several times
welcome[bot] commented 5 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

duplicate-issue-bot[bot] commented 5 years ago

Hey @Fainirael,

We did a quick check and this issue looks very darn similar to

This could be a coincidence, but if any of these issues solves your problem then I did a good job :smile:

If not, the maintainers will get to this issue shortly.

Cheers, Your Friendly Neighborhood ProBot

thepappas commented 5 years ago

I just had this problem. The MiniPlayer just kept getting bigger and bigger and bigger; like it just keeps zooming out and the window grows to accommodate. Like a balloon. Tried uninstall and reinstall, but that did not work, so I had to delete the following folders after uninstall before the next reinstall to fix: C:\Users\USER\AppData\Roaming\Google Play Music Desktop Player C:\Users\USER\AppData\Local\GPMDP_3

It deletes all the settings and forces a relogin. Seems to fix the creeping miniplayer as well.

It seems to have something to do with choosing system window borders. Once I do that, it starts creeping. Unchecking that box stops the behavior, but there is still weird visual artifact that shows that at one time it was selected and deselected. The Uninstall+Dir Delete fixes it back to normal function.

This behavior is not reproducible on my desktop system as System Borders work fine. This behavior is reproducible on my test SP3, where GPDMP has never been installed. Simply checking system window borders and restarting as required to enable. Same on SP6. My desktop does not have a touch screen.

@Fainirael, is your system touchscreen equipped?

Systems in play: HP Desktop: Win10 Ent 1903 b18362.145 SP6: Win10 Ent 1903 b18362.145 SP3: Win10 Ent Insider 1903 b18912.rsprerelease.190601-1739

hkystar35 commented 5 years ago

Confirming the behavior reported by @thepappas and @Fainirael

Steps to reproduce:

  1. Open GPMDP
  2. Open Desktop Settings
  3. Check box for "Use system window borders"
  4. Quit and relaunch GPMDP
  5. Click button for MiniPlayer
  6. Watch the window groooooooooow until it fills the screen or you catch the button to return to regular window
  7. Open Desktop Settings
  8. UNcheck box for "Use system window borders"
  9. Quit and relaunch GPMDP
  10. Click button for MiniPlayer
  11. MiniPlayer functions as designed

Video: https://youtu.be/ZkfJ8qUZT_Y

System info: GPMDP Version 4.6.1 Windows 10 Ent 1803 (10.0.17134.829)

thepappas commented 5 years ago

That about sums it up! On one of my freshly loaded windows 10 boxen it behaves properly, but noton another one of my systems. I cannot isolate the difference at this point.

Thanks for looking into this! I love the software and use it every day.

On Fri, Aug 2, 2019 at 1:17 PM hkystar35 notifications@github.com wrote:

Confirming the behavior reported by @thepappas https://github.com/thepappas and @Fainirael https://github.com/Fainirael

Steps to reproduce:

  1. Open GPMDP
  2. Open Desktop Settings
  3. Check box for "Use system window borders"
  4. Quit and relaunch GPMDP
  5. Click button for MiniPlayer
  6. Watch the window groooooooooow until it fills the screen or you catch the button to return to regular window
  7. Open Desktop Settings
  8. UNcheck box for "Use system window borders"
  9. Quit and relaunch GPMDP
  10. Click button for MiniPlayer
  11. MiniPlayer functions as designed

System info: GPMDP Version 4.6.1 Windows 10 Ent 1803 (10.0.17134.829)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3567?email_source=notifications&email_token=ABWHJAMHUDWPIOMKFEOG6QLQCSB27A5CNFSM4HN4LOT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OTVZA#issuecomment-517815012, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWHJAO2L5MK5EUSULBPTF3QCSB27ANCNFSM4HN4LOTQ .

ZombieCaptain commented 5 years ago

I think the issue is due in part to having two monitors, each with different resolutions.

Going from having two 2560x1440 monitors, I never had the problem. Once I swapped my main monitor out with a new widescren, 3440x1440 monitor, anytime the mini-player is on my secondary, 2560x1440 monitor, it starts to enlarge.

Moving the mini-player back to my 3440x1440 monitor, and it doesn't enlarge.

Hope this helps!

Edit 1: I should say that I have "Use system window borders" unticked.

Edit 2: With "Use system window borders" ticked, the behavior no longer occurs - UNTIL - I move the window. Then it will enlarge for approximately 1 second before stopping.

elvispocomo commented 4 years ago

To further expand on the last comment (pun intended), the display it happens on for me is scaled to 125% of the regular size rather than anything to do with resolution settings. I had that set for an app I was using on that part of the desktop to make it more legible.

I just tested with the Scale and Layout setting back to 100% and it no longer experiences the issue of continually expanding.

Today just happened to be the first time looking at the mini player as that app was just updated to a web version. I couldn't tile the multiple instances the way I wanted, and then remembered I had the scale increased but didn't need it any more (as I could set that within the browser).

jimmyjwalker commented 3 years ago

This is still happening, but I've determined it is being caused by having Windows Scaling function active on the monitor. No scaling, no growing player. Turn on scaling, the player grows.