search

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 766 forks source link

Google Advanced Protection blocks authentication #3573

Open cautionbug opened 5 years ago

cautionbug commented 5 years ago

Love this application. ... But... ;)

OS: Windows 10

GPMDP Version: 4.6.1

Issue Descriptions: i recently updated my Google account security to the "Advanced Protection" that requires use of a USB or Bluetooth key for 2FA. There are still some wrinkles and i'm considering disabling it as i discover issues.

But i wanted to raise the issue here that after enabling this feature, all devices (and applications) the Google account is linked to get logged out.

When i tried to log back in to GPMDP i was asked to connect my security key. i did so, but the application didn't detect it. Other applications like Chrome and Firefox have recognized the key, so i'm pretty sure it's working.

Steps to Reproduce:

  1. Enable Advanced Protection on Google account (https://g.co/advancedprotection) with a physical security key (i have Titan)
  2. During the process, you're informed that all devices will be logged out. Confirm and verify that GPMDP has been logged out.
  3. Attempt to login: Security Key prompt
  4. i tried both the USB and BT keys linked to my account, and neither were recognized.
  5. i clicked the "Try another way" link. But because i have AP enabled, i see this: Try another option

i realize these screens are embedded web views of Google's own login pages, but if i can use the key with the actual browser, shouldn't it work in the application as well?

Currently i'm stuck with no access to the application. Let me know what additional info i can provide to help out.

welcome[bot] commented 5 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

eblis commented 5 years ago

I encountered the same issue but I also have Google Authenticator for the account and could use the generated number to log in (might help you out while this is sorted).

cautionbug commented 5 years ago

@eblis Google's new "Advanced Protection" system only permits the security key for 2FA (see the second screenshot). So far since enabling it, i've only used an alternate method once, and it was a "Yes" tap on my phone, automatically prompted by whatever app that was (i don't recall). Everything else has required the key.

Thanks for the suggestion though.

pconwell commented 5 years ago

Probably related to #3343 which is related to a bunch of other electron issues. Long story short, looks like electron 4/chromium 68 supports u2f/security keys. Presumably GPMDP could be updated to e4/c68 and the security keys should work.

cautionbug commented 5 years ago

@pconwell Certainly looks that way based on that thread. Thanks for finding that.

Hopefully @MarshallOfSound will have a look at these and look into upgrading.

JohnLGalt commented 5 years ago

Chalk another one up who is unable to use GPMDP because of Advanced Protection on my account.

CatFoxVoyager commented 5 years ago

Chalk another one up who is unable to use GPMDP because of Advanced Protection on my account.

Hi! If you using the last build from 6 days ago, it will works with code. It don't recognize the key, but I can log in correctly with authy.

https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/branch/master/artifacts

JohnLGalt commented 5 years ago

Chalk another one up who is unable to use GPMDP because of Advanced Protection on my account.

Hi! If you using the last build from 6 days ago, it will works with code. It don't recognize the key, but I can log in correctly with authy.

https://ci.appveyor.com/project/MarshallOfSound/google-play-music-desktop-player-unofficial/branch/master/artifacts

You're saying it works with a code? With Advanced Protection enabled (not 2-Step Verification, but specifically Advanced Protection)?

Because the only mention of any 'codes' is for iOS apps...

https://support.google.com/accounts/answer/7539956?hl=en

pconwell commented 5 years ago

@JohnLGalt , I believe @jedduff is confusing 2FA in general (OTP specifically) with Advanced Protection (U2F).

Authy is an OTP code generator app. Advanced Protection does not use OTP.

CatFoxVoyager commented 5 years ago

I have advanced Protection with a yubikey. I enter my credentials. After that, it said "key not recognized" or something like that. But it gave me option to use my authy code

CatFoxVoyager commented 5 years ago

I use both, key and code

Le mar. 3 sept. 2019, à 11 h 02, Patrick Conwell notifications@github.com a écrit :

@JohnLGalt https://github.com/JohnLGalt , I believe @jedduff https://github.com/jedduff is confusing 2FA in general (OTP specifically) with Advanced Protection (U2F).

Authy is an OTP code generator app. Advanced Protection does not use OTP.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3573?email_source=notifications&email_token=AB5ATGIFTSVDA7L62XAIU3DQHZ4AZA5CNFSM4HQNPNL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5YP5IA#issuecomment-527498912, or mute the thread https://github.com/notifications/unsubscribe-auth/AB5ATGMPHM2XLIRXIXHXS73QHZ4AZANCNFSM4HQNPNLQ .

-- [image: photo] Jeremie Dufault

jedduff@gmail.com

jeremiedufault.ca http://facebook.com/jeremiedufault http://us.linkedin.com/in/jeremiedufault http://twitter.com/jedduff https://www.linkedin.com/in/jeremiedufault/

pconwell commented 5 years ago

@jedduff Advance Protection does not support OTP codes. You are using what Google calls "2-Step Verification", not Advanced Protection.

These are different things, you are using the 2nd one. We are talking about the 1st one in this issue:

JohnLGalt commented 5 years ago

Advanced protection stops use of codes. You're required to use keys.

On Tue, Sep 3, 2019, 11:04 jedduff notifications@github.com wrote:

I use both, key and code

Le mar. 3 sept. 2019, à 11 h 02, Patrick Conwell <notifications@github.com

a écrit :

@JohnLGalt https://github.com/JohnLGalt , I believe @jedduff https://github.com/jedduff is confusing 2FA in general (OTP specifically) with Advanced Protection (U2F).

Authy is an OTP code generator app. Advanced Protection does not use OTP.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3573?email_source=notifications&email_token=AB5ATGIFTSVDA7L62XAIU3DQHZ4AZA5CNFSM4HQNPNL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5YP5IA#issuecomment-527498912 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AB5ATGMPHM2XLIRXIXHXS73QHZ4AZANCNFSM4HQNPNLQ

.

-- [image: photo] Jeremie Dufault

jedduff@gmail.com

jeremiedufault.ca http://facebook.com/jeremiedufault http://us.linkedin.com/in/jeremiedufault http://twitter.com/jedduff https://www.linkedin.com/in/jeremiedufault/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3573?email_source=notifications&email_token=ABYWSQF6ZWITK6ZERZU2G4TQHZ4GZA5CNFSM4HQNPNL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5YQDEI#issuecomment-527499665, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYWSQF5UMAC4VRY7OE4KB3QHZ4GZANCNFSM4HQNPNLQ .

CatFoxVoyager commented 5 years ago

oh, thank you for the link. I didn't knew that.

Le mar. 3 sept. 2019, à 11 h 14, John L. Galt notifications@github.com a écrit :

Advanced protection stops use of codes. You're required to use keys.

On Tue, Sep 3, 2019, 11:04 jedduff notifications@github.com wrote:

I use both, key and code

Le mar. 3 sept. 2019, à 11 h 02, Patrick Conwell < notifications@github.com

a écrit :

@JohnLGalt https://github.com/JohnLGalt , I believe @jedduff https://github.com/jedduff is confusing 2FA in general (OTP specifically) with Advanced Protection (U2F).

Authy is an OTP code generator app. Advanced Protection does not use OTP.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3573?email_source=notifications&email_token=AB5ATGIFTSVDA7L62XAIU3DQHZ4AZA5CNFSM4HQNPNL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5YP5IA#issuecomment-527498912

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AB5ATGMPHM2XLIRXIXHXS73QHZ4AZANCNFSM4HQNPNLQ

.

-- [image: photo] Jeremie Dufault

jedduff@gmail.com

jeremiedufault.ca http://facebook.com/jeremiedufault http://us.linkedin.com/in/jeremiedufault http://twitter.com/jedduff https://www.linkedin.com/in/jeremiedufault/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3573?email_source=notifications&email_token=ABYWSQF6ZWITK6ZERZU2G4TQHZ4GZA5CNFSM4HQNPNL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5YQDEI#issuecomment-527499665 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABYWSQF5UMAC4VRY7OE4KB3QHZ4GZANCNFSM4HQNPNLQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3573?email_source=notifications&email_token=AB5ATGKSMQAV7BM5K7HPTEDQHZ5OHA5CNFSM4HQNPNL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5YRH4I#issuecomment-527504369, or mute the thread https://github.com/notifications/unsubscribe-auth/AB5ATGKDA7CX5REZDT4V6WTQHZ5OHANCNFSM4HQNPNLQ .

-- [image: photo] Jeremie Dufault

jedduff@gmail.com

jeremiedufault.ca http://facebook.com/jeremiedufault http://us.linkedin.com/in/jeremiedufault http://twitter.com/jedduff https://www.linkedin.com/in/jeremiedufault/

JohnLGalt commented 5 years ago

No worries - it's a common mistake, actually.

arafey commented 4 years ago

Also having the same problem. Seems 4.7.1 doesn't fix it:

OS Version

macOS Catalina 10.15.2

GPMDP Version

4.7.1

Issue Description

It is not possible to sign into a Google account taking part in the Advanced Protection Program. The only sign in option showing up is username + password + security key and this does not work. I believe GPMDP is not able to access the Titan key over USB because the prompt asking for access to security keys never shows up. But the prompt that doesn't show up is the only way to enable alternative sign in options, such as via phone. See screenshots below for more info.

Signing in on Chrome

via Bluetooth
Screen Shot 2020-01-30 at 15 12 33
via USB
Screen Shot 2020-01-30 at 15 13 10
via phone
Screen Shot 2020-01-30 at 15 13 22
successful login
Screen Shot 2020-01-30 at 15 13 40

Signing in on GPMDP

security key communication failure
Screen Shot 2020-01-30 at 15 11 23
failed login
Screen Shot 2020-01-30 at 15 11 47

Steps to Reproduce

  1. Join Advanced Protection Program here.
  2. Attempt to sign into your Google account using GPMDP.
temosy commented 4 years ago

I'm facing same issue.

OS Version: macOS Catalina 10.15.3
GPMDP Version: 4.7.1

Details: https://youtu.be/swwlYSfSJAY

raviskottada commented 4 years ago

I too face the same issue. Catalina 10.15.3. None of the methods in the advanced protection are being recognized. Hope some fix appears soon. Thanks a lot.

tweak42 commented 4 years ago

Same problem using a Yubikey Ubuntu 18.04 GPMDP Version: 4.7.1

jared001 commented 4 years ago

Same problem for me

danielblakes commented 4 years ago

This issue continues to prevent users of Advanced Protection from being able to use this app.

andresvalera commented 4 years ago

Same issue here. It just bypasses the screen that asks for the key to be input