search

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 766 forks source link

Suggestion about RPC #3577

Closed ghost closed 5 years ago

ghost commented 5 years ago

Suggestion: can put the image of artist instead google play image Suggestion2: can change the discord rpc "game" name to Youtube Music instead google play music when using ytmusic Suggestion3: if the first suggestion not "the best", can only put yt icon when using ytmusic

Bug: image sometimes using Youtube Music, you can see "Unknown Artist"

Big thank you for the attention.

welcome[bot] commented 5 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

jostrander commented 5 years ago

To answer your suggestions:

1 is not possible, due to the way the integration works. The image presented has to be uploaded to discord ahead of time and referenced by name, making that impossible.

  1. Possible, but I believe it was discussed the player name is the reason that is displayed, and until they shut down GPM that's the way @MarshallOfSound intended to keep it.
  2. Same as above, the icon is the player icon, even though it resembles the GPM icon.

As for unknown artist, I believe that's an issue with the underlying implementation.