search

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 767 forks source link

Stuck on "Loading music library" #3640

Closed Azhag closed 5 years ago

Azhag commented 5 years ago

OS: Debian GNU/Linux rodete

GPMDP Version: 4.6.1

Issue Descriptions: Since last week, opening the app does not show anything, instead I get stuck on a "Loading music library" page

Steps to Reproduce:

  1. Open the app
  2. Stuck on loading page, nothing working.
welcome[bot] commented 5 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already. To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

ryanjuza commented 5 years ago

Same issue on Windows on all PC's I have using it.

  1. Open GPMDP from pinned taskbar icon, system icon, or other method.
  2. Player never gets beyond "Loading Music Library," progress bar does not move at all.
ikstro commented 5 years ago

I have the same problem от Windows 10 on Laptop and Desktop.

  1. Start GPMDP 4.6.1 from Menu or Desktop Icon.
  2. Player stops on window "Загрузка Фонотеки" (Loading Music Library).
  3. Uninstall GPMDP and clear the registry .
  4. Install GPMDP 4.6.1
  5. Player stops on window "Загрузка Фонотеки" (Loading Music Library).

Фигня

tpetersen50 commented 5 years ago

Same here. Started yesterday for me.

rameezv commented 5 years ago

+1 happening on Debian x64 for the last few days as well. Tried completely removing and reinstalling, as well as building from source (yarn run make:deb:64) and installing, nothing works.

EDIT: Also seeing the bonjour service error @timmyleahy mentioned

jason-mehmel commented 5 years ago

+1 here too, installed newest version, Ubuntu Linux 18.04

timmyleahy commented 5 years ago

+1 Mac Pro, OSX 10.14.6, GPMDP 4.6.1

Did full uninstall (removed app and ~/Library/Applications/GPMDP dir) and reinstalled. Authenticated user account. Hanging on "Loading Music Library..." screen.

Tried downgrading to 4.6.0 and that made no difference, still hangs on "Loading Music Library..." screen after authenticating.

Not sure if this is related but I looked at the ~/Library/Applications/GPMDP/gpmdp.log and saw an error:

{"level":"info","message":"Application started.","timestamp":"2019-10-10T19:54:34.169Z"}
{"level":"error","message":"Failed to load bonjour with error: {}","timestamp":"2019-10-10T19:54:34.629Z"}
Chronos-Sk commented 5 years ago

Possibly related, but this loading issue first started for me when the website certificate expired (GH-3639).

jatk commented 5 years ago

Running into the same issue of Windows 10

jostrander commented 5 years ago

Not sure why this is happening. It's more than likely a problem in the player causing an error that prevents GPM from loading. If that's the case these steps may not work, but if you can try them anyway:

  1. Press CTRL + SHIFT + G
  2. Enter (without quotes): "DEV_MODE"
  3. Click Go
  4. You should now be in dev mode, and able to open developer tools from either the menu or by using CTRL + SHIFT + i This is the main window console, you may see errors, take a screenshot or copy and paste and errors from this console. In addition to this you can type openGPMDevTools() Enter and it will open another console, you may have more errors here, copy these as well.
jatk commented 5 years ago

Not sure why this is happening. It's more than likely a problem in the player causing an error that prevents GPM from loading. If that's the case these steps may not work, but if you can try them anyway:

1. Press CTRL + SHIFT + G

2. Enter (without quotes): "DEV_MODE"

3. Click Go

4. You should now be in dev mode, and able to open developer tools from either the menu or by using CTRL + SHIFT + i
   This is the main window console, you may see errors, take a screenshot or copy and paste and errors from this console.
   In addition to this you can type `openGPMDevTools()` Enter and it will open another console, you may have more errors here, copy these as well.

Running into these errors: Console: image

GPMDevTools: image

jostrander commented 5 years ago

I don't have access to listen_v2.js, as I'm being served listen.js. However, that is a weird error being thrown. window.customElements.upgrade is a function when I test it on the current release, so it shouldn't be throwing an error.

kerfall commented 5 years ago

Same error on windows 10 started friday morning. But youtube Music is still working tough.

dobesv commented 5 years ago

I get the same console errors as above. If I clear cookies and reload, it asks me to login again, but after login it goes to the same place.

I wonder if it is trying to show some kind of "upgrade" UI to some users based on their account status, and that thing is failing to load in this app environment.

sebsebmc commented 5 years ago

In a regular Google Play Music tab window.customElements.upgrade is a native function, and chromestatus.com shows it as added in Chrome 68 https://chromestatus.com/features/5967337471606784

The package.json lists electron 3.1.8 which seems to be Chromium 66.0.3359.181

It seems like the fix would be to upgrade Electron to at least version 4.0

sebsebmc commented 5 years ago

I can confirm that the artifact from the WIP Electron 4 PR https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/pull/3588 does seem to get past the Loading Music Library screen. Hopefully this can get merged before listen_v2.js is rolled out to everyone.

dobesv commented 5 years ago

Ah interesting, maybe this just needs to ship a new build with newer version of the Chrome engine in it?

b0g3r commented 5 years ago

I see the same error for 4 days :(

ddsol commented 5 years ago

You can start it with the following DEV_MODE (see above) workaround:

On the GPM devtools (see above) console, put a breakpoint on listen_v2, line one. Then refresh the page, and enter window.customElements.upgrade = () => undefined [enter] and then continue running the script. It magically doesn't need the upgrade function because just setting it to something that does nothing at all makes it work.

In any case, it allows you to use your GDP with some pain at startup. You can close the DevToolss (?? plural2) and use the player as normal from there on in.

This could also be a quick hack fix if upgrading to Electron 4 is troublesome.

crayfishuk commented 5 years ago

Also had this - and now can't reinstall - the RELEASE file URL ( in squirrelsetup.log https://update.gpmdp.xyz/update/win/4.6.1/RELEASES?id=GPMDP_3&localVersion=4.6.1&arch=amd64 ) returns

API rate limit exceeded for user ID 46058608.
altblog commented 5 years ago

Windows 10. DEV_MODE say:

Local\GPMDP_3\app-4.6.1\resources\app.asar\node_modules\react\lib\lowPriorityWarning.js:38
Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in  React v16.0. Use the latest available v15.* prop-types package from npm instead.

Pls fix it!

jostrander commented 5 years ago

@altblog that's just a warning, and it won't stop it from starting. The issue above is the real problem.

ddsol commented 5 years ago

Fix available (for Windows, at least):

tpetersen50 commented 5 years ago

Fix available (for Windows, at least):

  • Install 7zip (at your own risk)
  • Install Asar7z (at your own risk, it could have a large number of hairy viruses)
  • Make sure GDMP is closed, exited and shut down
  • Find your GDMP install (C:\Users\You\AppData\Local\GPMDP_3\app-4.6.1\resources)
  • Make a backup copy of app.asar to app.asar.backup in the same folder
  • Open app.asar with 7zip (open as archive)
  • In 7zip, navigate to build\renderer\windows\GPMWebView\
  • Drag index.js from there to your desktop or some folder
  • Edit the file with an editor that can handle linux file endings (not Notepad, but you can use Notepad++ at your own risk)

  • Change

    function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

global.isGPM = true;

    to

    function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

window.customElements.upgrade = window.customElements.upgrade || function(){};

global.isGPM = true;

    (If you can't find it because your version is different, you can add the line at the top, the bottom, or anywhere outside a block)

  • Save it or it's as if you did nothing
  • Drag the index.js file back into 7zip into the same GPMWebView packed folder where you got it from, and when 7zip as asks if you want to copy the file into the archive, you can say "yes" because you made a backup so if you made a mistake you can put it back to it's original non-functional state.
  • Close 7zip
  • Start your music player, it should work now
  • Clean up the straggling index.js and if you're happy, confident and brave, your app.asar.backup. Also, clean your desk.
  • Do this each time you want to run it.
  • Just kidding, it'll work from now on.

Seemed to work for me. Thanks!!!

dobesv commented 5 years ago

FWIW instead of copying the file out to edit it, I just used the edit option in the 7-zip right click menu, it copies it to a file for you and when you change that file it offers to update the zip file.

ddsol commented 5 years ago

Yes, but that doesn't work if Notepad is your default editor due to bad line ending handling. That's why the long version...

dobesv commented 5 years ago

Actually I made the change using notepad and it didn't cause a problem.

ddsol commented 5 years ago

My bad I never went to W10 because GetWindows10 gave me a bad taste continued with Windows Spyware integration. Of course MS improved Windows massively by adding LF support and I was unaware. Are there any other changes in W10 that are important or matter in any way I should be aware of? Nvm... this is not a chat room...

dobesv commented 5 years ago

For me, Windows 10 is the best Windows version. Lots of little improvements all over the place. Better notepad, dark mode, command line, etc.. But I know there are some in your face items that annoy people. I think they might have annoyed me at first but over time I've gotten used to it and forgotten what they are.

JAgostoni commented 5 years ago

Fix available (for Windows, at least):

  • Install 7zip (at your own risk)
  • Install Asar7z (at your own risk, it could have a large number of hairy viruses)

Worked great! Instead of using Asar7zip I installed the asar NPM package: npm i -g asar

Then I just extracted the package, backed-up/edited the file as you stated above, then re-packed it: asar e app.asar app ... edit file ... asar p app app.asar

kolaval commented 5 years ago

Can anybody share their fixed app.asar?

cable729 commented 5 years ago

Same is happening to me (4.6.1), although youtube music mode works.

eric-wag commented 5 years ago

Happening for me on macOS mojave

crayfishuk commented 5 years ago

@tpetersen50 thanks! app-asar.zip Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

ddsol commented 5 years ago

It was actually me that came up with the fix. tpetersen50 just quoted me.

tpetersen50 commented 5 years ago

It was actually me that came up with the fix. tpetersen50 just quoted me.

Yep, I take no credit for the fix!

kolaval commented 5 years ago

@tpetersen50 thanks! app-asar.zip Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

Works, Thanks

ben-jordanian commented 5 years ago

@crayfishuk your file works for me too, thanks for making it easy

rameezv commented 5 years ago

@MarshallOfSound any word on updating to electron 4 to fix this issue?

bitojoe commented 5 years ago

For Mac users, you'll want to open your ~/applications/ folder, ctrl-click the app > "Show package contents" and then navigate and continue using @ddsol's instructions. (Thanks for a solution btw)

One difference is that I used Electrons asar command line tool which you can checkout here: https://github.com/electron/asar

mpwm commented 5 years ago

UPDATE: I tried the same thing as @chemicaldanny below, and it worked fine in Catalina. (Specifically, replacing my own app.asar file with the one in that zip file.)

@bitojoe I don't suppose you'd be willing to explain in a bit more detail how you did that, would you? I'm pretty new at all this (though I do have a fair amount of experience with javascript and web development). I just did a fresh install on Catalina on my MacBook Pro (Retina, 15-inch, Mid 2015), and I'm experiencing the same problem. I tried to follow your instructions, but I'm just getting a javascript error.

chemicaldanny commented 5 years ago

@tpetersen50 thanks! app-asar.zip Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

Thanks! Worked for me (OSX 10.12.6), gonna patch my windows machine at home tonight.

ajbobo commented 5 years ago

@tpetersen50 thanks! app-asar.zip Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

Worked for me. Thanks!

eythian commented 5 years ago

I don't know for sure if it's related, but now GMDP doesn't seem to populate the hamburger menu with its own settings option, nor does it respond to media keys for me.

JacqylFrost commented 5 years ago

@tpetersen50 thanks! app-asar.zip Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

Works great, thanks for saving me the trouble!

cable729 commented 5 years ago

Instead of patching, can we fix this and release an update?

dobesv commented 5 years ago

I guess @MarshallOfSound is not maintaining this project or something. Or just on a long holiday. Or just hasn't gotten around to it yet?

Chronos-Sk commented 5 years ago

What's the etiquette on poking a project maintainer?

(Also, updated app.asar worked for me. Thanks!)

jostrander commented 5 years ago

I could PR this in for a fix, but ultimately it wouldn't get released until @MarshallOfSound creates the release, windows and mac builds are signed with his certs/keys.

MikeKing67 commented 5 years ago

@tpetersen50 thanks! app-asar.zip Here's my patched one. It's just got the extra line added as per @tpetersen50 - but use at your own risk.

Thanks, that sorted this issue for me!!!