search

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 767 forks source link

Thumbs up/down hotkeys not working #3754

Open cwinters8 opened 4 years ago

cwinters8 commented 4 years ago

Thumbs up and down hotkeys are not working for me. The 'You just liked...' notification pops up, but the song itself does not reflect that you have 'liked' it. Other hotkeys are working fine (play/pause, next track, etc). I don't see any recent issues with this particular problem, so opening a new one.

I am looking at the code now and the only thing I can think of is maybe the playback:thumbsUp action has changed on the Google side? I don't know how to begin to debug this or find out what action is expected to be passed. I'd be happy to try digging into this with a little direction.

debug_info.zip

Checklist:

OS: MacOS Mojave 10.14.6

GPMDP Version: 4.6.1 (built from current master branch)

Issue Descriptions: Unable to use the thumbs up/down hot keys, no matter what they are set to.

Steps to Reproduce: Set a custom hotkey for thumbs up or down, then try to use it (doesn't matter if you are focused on the app or not).

welcome[bot] commented 4 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already.

To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

mlidbom commented 4 years ago

I'm having the same issue. It is unfortunately still present in the 4.7.0 RC build that I just installed.

reduckted commented 4 years ago

This might be caused by https://github.com/gmusic-utils/gmusic.js/issues/26

There's a pending PR for it (https://github.com/gmusic-utils/gmusic.js/pull/27), but the build for that repo seems to be broken at the moment. 😢

bigdust1209 commented 4 years ago

This is also happening to me. Super annoying unfortunately.