search

MarshallOfSound / Google-Play-Music-Desktop-Player-UNOFFICIAL-

A beautiful cross platform Desktop Player for Google Play Music
https://www.googleplaymusicdesktopplayer.com
MIT License
8.27k stars 766 forks source link

YouTube Music Doesn't Automatically Skip Disliked Songs #3878

Open andrewjmetzger opened 4 years ago

andrewjmetzger commented 4 years ago

Checklist:

OS: Pop!_OS 20.04 LTS

GPMDP Version: 4.7.1 (deb)

Issue Descriptions: In YouTube Music mode, disliked songs are never skipped during playback.

Steps to Reproduce:

  1. Switch to YouTube Music mode using the button in the upper-right, or the tray icon.
  2. Using the tray icon, open Desktop settings.
  3. Select the Playback. tab, and ensure Automatically skip disliked songs is checked.
  4. Queue any song, followed by a disliked song, and then another song.
  5. Result: All three songs are played.

Expected behavior: Songs that are liked or have no rating play. Songs that are disliked do not play.

What actually happens: All songs play, even if disliked or rated with a thumbs down.

EndangeredNayla commented 4 years ago

Simple answer. This is google play music desktop player not youtube music desktop player. Try this

https://ytmdesktop.app/

andrewjmetzger commented 4 years ago

Thanks for the link. However, GPMDP also supports YTM.

Until a maintainer closes YTM issues as "wontfix" or decides to drop YTM support altogether, issues like this are a valid concern for GPMDP, despite the name of the project.

See also: Issue #3841.

andrewjmetzger commented 4 years ago

@CrankySupertoon YTM Desktop, which you linked above, does not currently support the desired feature. GPMDP does support this with GPM, but not for YTM. When you suggest an alternative, please make sure it is a comparable replacement.

EDIT: As of v1.13.0-R2, YTM Desktop now supports skipping disliked songs. See https://github.com/ytmdesktop/ytmdesktop/issues/334.

returnvisit commented 4 years ago

me too. In YouTube Music mode, disliked songs are never skipped during playback

Block81838 commented 4 years ago

Simple answer. This is google play music desktop player not youtube music desktop player. Try this

https://ytmdesktop.app/

This is freakin lag, a real resource killer

andrewjmetzger commented 4 years ago

@Block81838 Agreed, although I don't see any feature-comparable alternatives, since the official site on desktop can also be a resource killer. With development of GPMDP all but ceased, it's not like we have many options.

As time goes on, I'm sure YTM Desktop will continue to improve. For now, I'd suggest pulling the development branch, where all the latest improvements are happening.

Block81838 commented 4 years ago

@andrewjmetzger does gpmdp no longer develop?

andrewjmetzger commented 4 years ago

Agreed, Electron is a resource killer. If I knew how, I would update GPMDP to be YTM Desktop 2.0 (or similar) and remove the GPM branding to breathe some life back into this project so that we could avoid electron altogether. Alas, I have no clue how to do any of that.

does gpmdp no longer develop?

Since Google Play Music is shutting down at the end of October 2020, this project needs a major update to shift its support to YouTube Music. Unfortunately, GPMDP's commit history shows that the last commit on 2020-08-10 was a translation patch--and nothing new has been added been added since July.

Several issues have been raised to discuss the future of this project, but with no clear word from the project maintainers as to the path forward for GPMDP, it seems that YTM Desktop is the least worst replacement for now.

christofdamian commented 4 years ago

Having just had to fix an issue in ytmdesktop I would be happy to see GPMDP remove Google Music and focus on YTM. The code of GPMDP is just much nicer to work with.

returnvisit commented 4 years ago

agreed.

On Tue, Oct 13, 2020 at 2:53 AM Christof Damian notifications@github.com wrote:

Having just had to fix an issue in ytmdesktop I would be happy to see GPMDP remove Google Music and focus on YTM. The code of GPMDP is just much nicer to work with.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/issues/3878#issuecomment-707629960, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARCLP6JYOTZFBC6XGJ7BJKDSKQPTNANCNFSM4QFICLRQ .