Add a session parameter to install to allow installing extensions on a non-default session

MarshallOfSound / electron-devtools-installer

An easy way to ensure Chrome DevTools extensions into Electron

MIT License

1.12k stars 138 forks source link

Add a session parameter to install to allow installing extensions on a non-default session #150

Open tec27 opened 4 years ago

tec27 commented 4 years ago

My app doesn't use the default session, and electron doesn't seem to expose a way to change session.defaultSession, so I needed some way to specify which one to use when installing extensions. This just adds another parameter to install, defaulting to session.defaultSession as before.

I'd add a test as well, but since the tests are still using electron 7.x, I don't think it'd have any effect.

Fixes #134.

Dianoga commented 2 years ago

Is there anything blocking this from getting merged (other than conflicts now)? It would be helpful for my use case as well.

JaKXz commented 9 months ago

Sorry to comment on an old PR - curious if anyone has published this for themselves to use in a fork?