search

MarshallOfSound / electron-devtools-installer

An easy way to ensure Chrome DevTools extensions into Electron
MIT License
1.11k stars 136 forks source link

. #235

Closed Simon-Laux closed 1 year ago

Simon-Laux commented 1 year ago

react dev tools are not working for me since electron 11, we have electron 22 right now and there are still not working.

Edit: removed inappropriate part of this issue

MarshallOfSound commented 1 year ago

The issues you mentioned are completely unrelated to this package, Electron Dev Tools have been working for me up until Electron 23 (which we are currently looking into why it started failing).

Speaking as an Open Source Maintainer, you don't get to declare when a project is unmaintained. And interestingly enough engaging with maintainers in that way is a fantastic way of getting yourself blocked everywhere 🤔

Simon-Laux commented 1 year ago

sorry for my tone, you're right that was completely out of place and I apologise for it, and seems like I was wrong... 🤦 react dev tools give me an error, I'll file a proper issue later (already exists, points to an issue in the react dev tools), (though many issues are open without activity on this repo about the react dev tools, so my conclusion that there are unaddressed problems is not completely wrong, still my tone was.) redux dev tools work, so it seems only to be an issue with the react dev tools.

So electron-devtools-installer is just an installer, react dev tools get installed, they just don't work (because the extention was updated and now does not work in electron anymore). so it was just bad luck on my side that every time I tried to get it running it failed with various errors. That still does not justify me to jump to conclusions and write inappropriate aggressive issues. I'm sorry for that, I'll make sure that this never happens again.

Anyways thanks for the helpful answer to my completely in appropriate issue.