MarshallOfSound / react-electron-web-view

A simple wrapper to make Electrons WebView compatible with React
MIT License
64 stars 30 forks source link

Fixed build to exclude react & react-dom #12

Closed mhuggins closed 6 years ago

mhuggins commented 6 years ago

Since react and react-dom are peer dependencies, they should not be built into the distributable version of this package. This fixes #7.

MarshallOfSound commented 6 years ago

Cheers 👍

mhuggins commented 6 years ago

Awesome, thanks for merging! Would it be possible to publish a new release with this change? No rush or anything. 😄

mhuggins commented 6 years ago

Just thought I'd follow up to see if it would be possible for a new version to be published with this change. Thanks again!

mitchheddles commented 6 years ago

@MarshallOfSound Is there any chance you could publish this as a new version?