search

MartaAG / bestRestaurants

best restaurants in Wroclaw
1 stars 2 forks source link

Fix bugs #4

Closed MartaAG closed 3 years ago

MartaAG commented 4 years ago

For evaluation.

Udiknedormin commented 4 years ago 
$npm install
(...)
found 1 high severity vulnerability
(...)

^^^ please fix it!

Udiknedormin commented 4 years ago

A BIG problem with your alert: let's say I did realise my api key just expired or I mis-pasted it. I change it... and the communicate stays the same. If I was a user, I'd be puzzled as for why. A smart user would probably try to rebuild the project --- and that, indeed, helps --- but you know... the user was not-so-smart enough not to read README before using your service, so I'd not count on user's smartness if I were you.

Udiknedormin commented 4 years ago 
$ npm install
$ npm run serve
 WARNING  Compiled with 1 warnings                                      18:37:16

Module Warning (from ./node_modules/eslint-loader/index.js):

$MartaAG_bestRestaurants/src/views/ErrorCodes.vue
  24:14  warning  Replace `'403'` with `"403"`  prettier/prettier
  29:14  warning  Replace `'404'` with `"404"`  prettier/prettier

✖ 2 problems (0 errors, 2 warnings)
  0 errors and 2 warnings potentially fixable with the `--fix` option.

(...)

^ please fix it