search

Martchus / syncthingtray

Tray application and Dolphin/Plasma integration for Syncthing
https://martchus.github.io/syncthingtray/
Other
1.68k stars 44 forks source link

[Linux] Launcher argument '-no-console' doesn't exist/work on Linux and causes it to fail #106

Closed newtant closed 3 years ago

newtant commented 3 years ago

Relevant components

Environment and versions

Bug description Syncthing Tray -> Settings -> Startup -> Syncthing launcher

The automatically populated arguments include '-no-console' which, according to man syncthing, doesn't exist/work on Linux and causes the automated launch of Syncthing to fail with syncthing: error: unknown flag --no-console.

Steps to reproduce

  1. Activate the "Launch Syncthing when starting the tray icon" option on Linux
  2. Observe if '-no-console' has been added to the list of arguments by default
  3. Relaunch the program or reboot the machine
  4. Check if Syncthing has been successfully started
  5. If not check the logs

Expected behavior Syncthing is successfully started when starting the tray icon.

Screenshots image

Additional context The Syncthing error message itself weirdly contains an additional hyphen which isn't present during input nor a valid argument according to its manpage.

Martchus commented 3 years ago

These are just suggested defaults, you can always replace them with whatever you want. Of course it makes sense to omit -no-console on any platforms other than Windows (like the .exe suffix of the default executable name is omitted).

Martchus commented 3 years ago

I changed the default arguments so this should be fixed in the next release. You likely won't see a difference when you've already launched Syncthing Tray because existing settings are not replaced.

newtant commented 3 years ago

Thank you, and absolutely, I get that these are just suggested defaults. I didn't write this bug report to get a fix for the problem on my end, I obviously did take care of that myself already, I opened this issue because I think the defaults should work for most users.

Thanks again!

Martchus commented 3 years ago

The change will be part of the next release so I'm closing this issue.