Wrong UI layout on KDE Plasma

Martchus / syncthingtray

Tray application and Dolphin/Plasma integration for Syncthing

https://martchus.github.io/syncthingtray/

Other

1.6k stars 43 forks source link

Wrong UI layout on KDE Plasma #120

Closed mrpink17 closed 2 years ago

mrpink17 commented 2 years ago

Relevant components

[x] Standalone tray application (based on Qt Widgets)
[x] Plasmoid/applet for Plasma desktop

Environment and versions

syncthingtray 1.1.12-1
qtutilities 6.5.2-1
c++utilities 5.11.3-1
Qt Version: 5.15.2
C++ compiler (name and version): gcc version 11.1.0
C++ standard library (name and version): glibc 2.33-5
Operating System: Arch Linux
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0

Bug description The toolbar buttons are missing. Pause and Stop buttons have only text and are not clickable.

Steps to reproduce Click the tray icon

Screenshots Screenshot_20211120_235206

Martchus commented 2 years ago

I'm aware that the current release is quite broken - however, in my plasma shell it doesn't look that broken. Can you test against the current master? Maybe my recent fixes improve the breakage in your case as well.

kd8bny commented 2 years ago

Confirmed, the git version fixes the missing icon issues. Still have some minor clipping

Martchus commented 2 years ago

The clipping issue is likely https://github.com/Martchus/syncthingtray/issues/65. So I cannot do much about it when the Plasmoid is displayed as part of the system tray Plasmoid.

Note that the Plasmoid deserves a complete overhaul to be more in-line with official Plasmoids anyways. Then I'd likely move most of the buttons inside the usual hamburger menu so less horizontal space is required. The "side-tabs" are now also no longer used by any official Plasmoids and should likely be replaced by regular tabs. That would also save some horizontal space.

kd8bny commented 2 years ago

ah cool beans, saw that on the README as well. I went with the separate plasmoid for now, works fine. Thanks!

Martchus commented 2 years ago

I gave the Plasmoid a bit of a rework as stated in the previous comment. Also see https://github.com/Martchus/syncthingtray/issues/65#issuecomment-982916337.

Martchus commented 2 years ago

I'm closing this because due to the rework the issue should be fixed and #65 (for possible clipping) is still open.