search

Martchus / syncthingtray

Tray application and Dolphin/Plasma integration for Syncthing
https://martchus.github.io/syncthingtray/
Other
1.66k stars 44 forks source link

Use Plasma 6 system-wide icon theme for the plasmoid #197

Closed sten0 closed 1 year ago

sten0 commented 1 year ago

Continuing from #121

I suppose I actually needed to use the icons from the Plasma theme here (and not from the freedesktop icon theme).

It looks like this aspect is not going to be relevant in Plasma 6 anymore (see https://pointieststick.com/2023/07/26/what-we-plan-to-remove-in-plasma-6). Since it was the only improvement left to do I'm closing this issue.

Originally posted by @Martchus in https://github.com/Martchus/syncthingtray/issues/121#issuecomment-1666602069

Martchus commented 1 year ago

This is already possible like it is for Plasma 5. You just have to configure it in the settings and restart the shell.

The missing bit was using the Plasma theme specific icons but those seem to be going to be removed anyway so I've closed the original issue.

Martchus commented 1 year ago

Considering https://pointieststick.com/2023/08/12/how-all-this-icon-stuff-is-going-to-work-in-plasma-6 Plasma theme specific icons are definitely going to be removed. So I don't think there's anything left to do here since support for icons from the Plasma theme was the only missing bit and it is going to be obsoleted anyways.

sten0 commented 1 year ago

So this means that qtforkawesome will be dropped as a dependency, right?

On Sun, 13 Aug 2023 at 10:41, Martchus @.***> wrote:

Considering https://pointieststick.com/2023/08/12/how-all-this-icon-stuff-is-going-to-work-in-plasma-6 Plasma theme specific icons are definitely going to be removed. So I don't think there's anything left to do here since support for icons from the Plasma theme was the only missing bit and it is going to be obsoleted anyways.

— Reply to this email directly, view it on GitHub https://github.com/Martchus/syncthingtray/issues/197#issuecomment-1676380078, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWYOAMBYNENBMOBSI3PRA3XVDRQDANCNFSM6AAAAAA3FRS2RE . You are receiving this because you authored the thread.Message ID: @.***>

Martchus commented 1 year ago

No. It will always be a dependency because one can still change at runtime which icons to use. Also, the default of using ForkAwesome stays.

Note that the mapping of ForkAwesome icons to system theme icons is also implemented on level of the Qt ForkAwesome dependency.