search

Martchus / syncthingtray

Tray application and Dolphin/Plasma integration for Syncthing
https://martchus.github.io/syncthingtray/
Other
1.5k stars 42 forks source link

Tray Icon remains green when remote device is disconnected #248

Closed Lcchy closed 2 weeks ago

Lcchy commented 3 months ago

Relevant components

Environment and versions

Bug description When I shutdown the remote device ("linode" in the screenshot), syncthingtray, which is running on my pc ("lemur") , detects that the device is disconnected but the tray icon does not turn grey.

Expected behavior The tray icon turns grey to reflect the connection loss.

Screenshots screenshot_2024-Apr-10th_19h07m11s

When I pause the device from my pc, the tray icon behaves as expected: screenshot_2024-Apr-10th_19h17m03s

Ps: I would also like to receive a desktop notification about the connection loss, even though I have setup all notifications in the settings, that is not the case. Is this possible?

I am new to syncthingtray, and I hope that I have not simply overlooked some setting regarding my issue.

Martchus commented 3 months ago

It behaves actually as expected. I could add a setting to allow changing the behavior in the way you described. Should it turn gray if at least one remote is not connected or only if all remotes are not connected?

Adding a notification would also be possible.

Not sure when I'll find the time to implement this but I'd accept a PR. Just make sure the default behavior stays.

Lcchy commented 3 months ago

Ah I see, thanks for the quick reply!

In my use case it would make more sense for it to turn grey if at least one remote is disconnected.

I will look into the code and see if it seems doable for me to write a PR.

Martchus commented 2 months ago

If it is doable then let me know if you start coding so we're not duplicating the effort. (I'll also assign myself to this issue on GitHub when I'll find the time to work in it myself.)

Lcchy commented 2 months ago

Hi! Sorry I am having a busy time, I have looked at the code but I don't have enough time at the moment to be able to take it on.

stale[bot] commented 3 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.