At first installation, `unexpected argument serve` arrive form syncthing

Martchus / syncthingtray

Tray application and Dolphin/Plasma integration for Syncthing

https://martchus.github.io/syncthingtray/

Other

1.5k stars 42 forks source link

At first installation, `unexpected argument serve` arrive form syncthing #267

Closed SiriosDev closed 1 month ago

SiriosDev commented 1 month ago

Relevant components

[x] Standalone tray application (based on Qt Widgets)
[ ] Plasmoid/applet for Plasma desktop
[ ] Dolphin integration
[ ] Command line tool (syncthingctl)
[ ] Integrated Syncthing instance (libsyncthing)
[ ] Backend libraries

Environment and versions

Versions of syncthingtray: 1.5.3 (Cause at the moment scoop extras is not updated)
Operating system (name and version): Windows 11

Bug description After a first installation syncthingtray fails to start external syncthing due to an arguments error, syncthing.exe: error: unexpected argument serve. (Arguments by default)

Screenshots

Martchus commented 1 month ago

What default arguments do you suggest then? I copied the default arguments from how Syncthing is launched via systemd under Linux - maybe under Windows it needs to be called differently. Where is your syncthing.exe coming from and does it work if you use an absolute path (to be sure the right binary is invoked)?

Martchus commented 1 month ago

It works just fine here with the latest version of Syncthing Tray and Syncthing under Windows 11 (but nothing has changed here recently so I don't think updating to the most recent versions will help in your case). Probably your syncthing.exe is not actually Syncthing.

SiriosDev commented 1 month ago

I'm currently on Syncthing 1.27.8 “Gold Grasshopper” installed via scoop (main), syncthingtray 1.53 installed via scoop (extra), everything comes from the original repos, I tried using arguments manually and it gives the same error

Martchus commented 1 month ago

I tried using arguments manually and it gives the same error

That means it is definitely not the fault of the Syncthing Tray launcher then. In my tests syncthing.exe from the official Syncthing downloads on GitHub worked just fine with serve and my other default parameters. So your version of Syncthing behaves strangely. Note that I'm not using Scoop myself and looking into any issues specific to this packaging is out of scope for this issue tracker (but I can try to assist you a little bit).

SiriosDev commented 1 month ago

I'll try it from the official site and let you know if the problem persists

SiriosDev commented 1 month ago

Found the problem! the scoop shims includes serve argument.

Thank you for your help 💙

Martchus commented 1 month ago

No problem.