search

Martchus / syncthingtray

Tray application and Dolphin/Plasma integration for Syncthing
https://martchus.github.io/syncthingtray/
Other
1.57k stars 43 forks source link

Notifications/errors do not disappear even after resolving them using Syncthing Web GUI #87

Closed tomasz1986 closed 2 years ago

tomasz1986 commented 3 years ago

Relevant components

Environment and versions

Bug description

When SyncthingTray reports a notification/error, the tray icon changes into the one with an exclamation mark. In this state, if we go to the Syncthing's Web GUI and resolve the issues there, they do not get cleared in SyncthingTray. Basically, to get rid of the error state, we need to open SyncthingTray specifically, click on "New notifications", and clear them there again.

Steps to reproduce

  1. Start SyncthingTray and connect it to Syncthing.
  2. Cause an error state on purpose, e.g. by deleting a folder in the OS.
  3. Wait for SyncthingTray to change to the exclamation mark icon.
  4. Open Syncthing's Web GUI and resolve the problem there.
  5. SyncthingTray still remains in the error state.

Expected behavior

Now, I have no idea if there exists a simple solution for this, but it would be really nice if SyncthingTray could detect that Syncthing has already resolved the issue, and then clear its error state accordingly.

Screenshots

Additional context

Martchus commented 3 years ago

Is the folder itself still shown as broken? Or are you just talking about the overall status which still has the exclamation mark icon because there are unread notifications? If it is the latter the overall status should switch back as soon as you dismiss the notification in Syncthing Tray as well. I am not aware of a way to improve this. If the folder itself is really still shown as broken than that's a bug but I haven't noticed it so far.

tomasz1986 commented 3 years ago

Or are you just talking about the overall status which still has the exclamation mark icon because there are unread notifications? If it is the latter the overall status should switch back as soon as you dismiss the notification in Syncthing Tray as well. I am not aware of a way to improve this.

Yeah, this is the situation that I am talking about. Even though the notification has been dismissed in Syncthing itself, SyncthingTray requires to dismiss it separately again. It would be nice to be able to have it dismissed automatically, but is this even possible (i.e. to detect that the notification is no longer present in Syncthing)?

Martchus commented 3 years ago

When I remember correctly and nothing has changed in the last years it isn't possible. I also believe the same happens when one has multiple tabs of the official web UI open. There's https://docs.syncthing.net/rest/system-error-clear-post.html but I am not aware of any event (delivered via the event API) which would tell one that an error has been cleared.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.