search

MartensCedric / COMP371-Project

Git Repository for the project
0 stars 0 forks source link

SphereModel and WorldModel #76

Closed laemtl closed 4 years ago

laemtl commented 4 years ago

Refactoring of the model structure, now in a WorldModel class. Sphere class and enclosing of the initial model in a soccer ball. Incremental size up/down.

TODO: fix the scaling

Resolves #63 Resolves #73

laemtl commented 4 years ago

Can you move your comment in a new issue? We can address them later to not hold this PR. This PR intention is to implement the sphere model, not to create an appropriate shader (a separate task in my opinion). Size, camera position are also minor details that do not justify holding that PR given the short delay.

MartensCedric commented 4 years ago

ill just make the changes rn they arent so big

MartensCedric commented 4 years ago

a new shader isnt needed and the keys are gonna be fixed if the world is a sphere.

I pushed a commit fixing the above but not what is below

Also the vertices are the wrong side. We can't see the sphere from the inside.