Closed GoogleCodeExporter closed 8 years ago
Thanks for the feedback. This is something we hope to add to the library in
early
2010. Would you be interested in implementing it and committing to the project?
Original comment by api.ekol...@gmail.com
on 17 Dec 2009 at 8:47
Yes, sure. I can take care of proxy support and soap wsdl settings - all
configurable using settings.ini. Let me know how to proceed. Thanks.
Original comment by evey...@gmail.com
on 26 Dec 2009 at 7:26
I've added you as a contributor to the project and assigned this issue to you.
When
you are finished upload your patch as an attachment to a comment on this issue.
We'll
review it internally, and afterwards we can work on adding you as a committer
to the
project (requires a legal form, etc).
Information on how to check out the source code is available here:
http://code.google.com/p/google-api-adwords-php/source/checkout. Thanks for
contributing!
Original comment by api.ekol...@gmail.com
on 28 Dec 2009 at 4:24
Also, here is the form you will need to sign in before you can commit your code
to
the project:
Individual: http://code.google.com/legal/individual-cla-v1.0.html
or
Company: http://code.google.com/legal/corporate-cla-v1.0.html
You don't need to sign it right away, but if you aren't comfortable with the
terms
you may not want to start work on this feature.
Original comment by api.ekol...@gmail.com
on 28 Dec 2009 at 4:30
Please find the patch attached. Let me know what you think. Thanks.
Original comment by evey...@gmail.com
on 29 Dec 2009 at 8:11
Attachments:
Hi, this patch looks great, and I'd like to add it in to the next release.
Have you
had a chance to sign the contributor license agreement form linked above?
Original comment by api.ekol...@gmail.com
on 8 Feb 2010 at 4:53
Upon further consideration I wonder if it makes sense to add SOAP extension and
HTTP
proxy options to the settings.ini file. Since were are using ini_set() when we
find
this values, which is a global operation, does it just make sense to set these
values
in the php.ini file instead? These appear to be settings that you would want
to
enforce across your application, not just within the client library.
Original comment by api.ekol...@gmail.com
on 8 Feb 2010 at 5:26
This has been implemented and committed to the trunk. The settings.ini file
now has
options for proxy host, port, user and password.
http://code.google.com/p/google-api-adwords-
php/source/browse/trunk/src/Google/Api/Ads/AdWords/settings.ini
Let me know if this works in your environment.
Original comment by api.ekol...@gmail.com
on 9 Apr 2010 at 3:57
Original issue reported on code.google.com by
evey...@gmail.com
on 17 Dec 2009 at 6:07