search

Martialdelastic / google-api-adwords-php

Automatically exported from code.google.com/p/google-api-adwords-php
Apache License 2.0
0 stars 0 forks source link

Include non-null type and CrietrionType in __construct of classes extending Criterion #85

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What is the feature you would like to see added to the library?

Replace $type = NULL, $CriterionType = NULL with correct type/CriterionType per 
object extending Criterion

When would this feature be useful?

Any time instantiating a new Criterion object (Language, Proximity, etc)

Would you be willing to implement this feature and contribute it to the
project?

Yes

Original issue reported on code.google.com by i...@d2cmedia.ca on 29 Jan 2013 at 7:32

GoogleCodeExporter commented 8 years ago 
An error has occurred: SOAP-ERROR: Parsing WSDL: Couldn't load from 
'https://adwords-sandbox.google.com/api/adwords/mcm/v201206/ManagedCustomerServi
ce?wsdl' : failed to load external entity 
"https://adwords-sandbox.google.com/api/adwords/mcm/v201206/ManagedCustomerServi
ce?wsdl"

Original comment by h...@xtremeprog.com on 5 Mar 2013 at 5:23

GoogleCodeExporter commented 8 years ago 
RE: h...@xtremeprog.com

I think the Sandbox has been deprecated, you need to use Test Accounts. This is 
obviously however unrelated to the created issue.

Original comment by i...@d2cmedia.ca on 5 Mar 2013 at 2:46

GoogleCodeExporter commented 8 years ago 
If you're interested in receiving this feature, I suggest looking into patching 
the WSDL generator.

I fail to see the wider use case for this feature.

Original comment by api.pmat...@gmail.com on 26 Sep 2013 at 5:18