Martichou / rquickshare

Rust implementation of NearbyShare/QuickShare from Android for Linux and macOS.
GNU General Public License v3.0
1.38k stars 27 forks source link

bug: drag and dropping a link into the app view will make the app be a web browser #119

Open Maxmystere opened 4 months ago

Maxmystere commented 4 months ago

I found this kinda funny bug where drag and dropping an url onto the app will open that url in the app and kinda turn it into a web browser instead of preparing the link to be sent as text My guess is that it is the default behavior of the tauri framework

I'm on KDE Plasma (Steam Deck) with rQuickShare 0.8.2

Martichou commented 3 months ago

Issue is not present on macOS, I'll check with Linux later :)

Martichou commented 3 months ago

Not sure how you achieve to drag and drop a link, but not working neither on Ubuntu :/

Maxmystere commented 3 months ago

I can make a video if you want but for example I just select the text from my web browser and drag and drop it directly to the app (like you would do with a file for example)

103sbavert commented 3 months ago

For me, dragging an image from Nautilus straight up crashes the app while dragging an archive file didn't do anything at all.

Martichou commented 3 months ago

Do you mind sharing the logs?

103sbavert commented 3 months ago

Sure:

$ RUST_BACKTRACE=full rquickshare 
set_up_logging: level: Info
2024-07-11T20:45:35Z  INFO rqs_lib: TcpListener on: 0.0.0.0:46451
2024-07-11T20:45:35Z  INFO rqs_lib::manager: TcpServer: service starting
2024-07-11T20:45:35Z  INFO rqs_lib::hdl::mdns: Broadcasting with: SPC
2024-07-11T20:45:35Z  INFO rqs_lib::hdl::ble: BleListener: service starting
2024-07-11T20:45:35Z  INFO rqs_lib::hdl::mdns: MDnsServer: service starting

(rquickshare:47516): Gtk-CRITICAL **: 02:15:35.488: gtk_widget_get_scale_factor: assertion 'GTK_IS_WIDGET (widget)' failed

(rquickshare:47516): Gtk-CRITICAL **: 02:15:35.490: gtk_widget_get_scale_factor: assertion 'GTK_IS_WIDGET (widget)' failed

(rquickshare:47516): Gtk-CRITICAL **: 02:15:35.492: gtk_widget_get_scale_factor: assertion 'GTK_IS_WIDGET (widget)' failed

(rquickshare:47516): Gtk-CRITICAL **: 02:15:35.494: gtk_widget_get_scale_factor: assertion 'GTK_IS_WIDGET (widget)' failed
thread 'main' panicked at /usr/src/debug/r-quick-share/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/wry-0.41.0/src/webkitgtk/mod.rs:531:16:
called `Result::unwrap()` on an `Err` value: http::Error(InvalidUri(InvalidFormat))
stack backtrace:
   0:     0x626cd66ad9bf - <unknown>
   1:     0x626cd6475d7b - <unknown>
   2:     0x626cd667baf2 - <unknown>
   3:     0x626cd66af509 - <unknown>
   4:     0x626cd66aed2e - <unknown>
   5:     0x626cd66aff54 - <unknown>
   6:     0x626cd66af872 - <unknown>
   7:     0x626cd66af7c9 - <unknown>
   8:     0x626cd66af7b6 - <unknown>
   9:     0x626cd5f5dc92 - <unknown>
  10:     0x626cd5f5e0a5 - <unknown>
  11:     0x626cd6770bef - <unknown>
  12:     0x791de49fa64a - g_closure_invoke
  13:     0x791de4a2ace5 - <unknown>
  14:     0x791de4a1b5dc - <unknown>
  15:     0x791de4a1b842 - g_signal_emit_valist
  16:     0x791de4a1b904 - g_signal_emit
  17:     0x791ddedf5123 - <unknown>
  18:     0x791dde96eb46 - <unknown>
  19:     0x791dde96f21f - <unknown>
  20:     0x791ddeca1a6b - <unknown>
  21:     0x791dded418d3 - <unknown>
  22:     0x791ddec96588 - <unknown>
  23:     0x791ddec9a90d - <unknown>
  24:     0x791de3af0a9b - <unknown>
  25:     0x791de3af0b80 - <unknown>
  26:     0x791de3c8bab9 - <unknown>
  27:     0x791de3ced9e7 - <unknown>
  28:     0x791de3c8afc5 - g_main_context_iteration
  29:     0x791de43e3a3f - gtk_main_iteration_do
  30:     0x626cd602fb2d - <unknown>
  31:     0x626cd637604e - <unknown>
  32:     0x626cd6325132 - <unknown>
  33:     0x626cd5ff3a83 - <unknown>
  34:     0x626cd638cd7f - <unknown>
  35:     0x791ddd74ec88 - <unknown>
  36:     0x791ddd74ed4c - __libc_start_main
  37:     0x626cd5f8f2b5 - <unknown>
  38:                0x0 - <unknown>
Martichou commented 3 months ago

For the crash, unfortunately I won't be able to fix the issue as this is from a underlying library of Tauri I suppose. I guess you can still use the button to open the selection menu and go from there.

And for the original issue, I'm still not able to reproduce.. but as this is not that critical, I'm not going to spend a lot of time trying to fix it right now. Keeping this issue open for later or if anyone want to take the lead here :)

Maxmystere commented 2 months ago

I just tested on another tauri app (hoppscotch) and I reproduced it too so I guess the issue is caused by tauri Looking at their Issues I didn't find anything too relevant but I lack knowledge on Tauri

Here is a video example (sorry for the quality I just took obs default setting)

https://github.com/user-attachments/assets/4d2fdf9e-01c5-48b5-96da-ef9cc1984d61

Notice that I'm using the back button on the mouse to go back to the original rsync page at the end