Support client last transaction time (cltt) for IPv4, too

MartijnBraam / python-isc-dhcp-leases

Small python module for reading /var/lib/dhcp/dhcpd.leases from isc-dhcp-server

MIT License

123 stars 47 forks source link

Support client last transaction time (cltt) for IPv4, too #34

Open aaron-sierra opened 3 years ago

aaron-sierra commented 3 years ago

Add cltt support for IPv4 leases (requested in #31), like it has been for IPv6 leases.

This changes the prototype of the Lease6 class API by dropping the cltt positional argument, but I hope there is low risk that users are directly instantiating anything other than IscDhcpLeases.

This also adds a big FIXME questioning the reliability of data submitted with the problem case from #20 :grin:

coveralls commented 3 years ago

Coverage increased (+0.005%) to 99.211% when pulling dcbdfe5c1db7c2335d4a2f864fe284e9bd447fda on aaron-sierra:support-ipv4-cltt into 831b8277e8f2900db2446c3b823b03c7af034fb8 on MartijnBraam:master.