search

MartinBraquet / youtube-adblock

Firefox Add-On Skipping YouTube Ads in Less Than a Second
https://addons.mozilla.org/addon/youtube_adblock
The Unlicense
17 stars 2 forks source link

Skip download ads without pressing Skip Ad button #12

Open BluestoneDE opened 4 months ago

BluestoneDE commented 4 months ago

Summary

This is one remaining problem from #8. The addon won't skip download links if they exist at the end of an ad.

Reproduction

Steps to reproduce the behavior:

  1. In the popup set If Skip Available to Boost Ad
  2. Go on YouTube
  3. Click on any video with ads
  4. Keep refreshing until an ad shows up with a download

Expected Behavior

The ad gets skipped completely without clicking "Skip Ad".

Actual Behavior

The ad isn't skipped completely.

Screenshots

screenshot

Environment

MartinBraquet commented 4 months ago

Thanks for keeping an issue open about this. Maybe clicking on the button at that moment would work and not be detected. Hard for me to try out as I can't reproduce on any of my devices.

BluestoneDE commented 4 months ago

I already tried that. The button cannot be clicked via a script. It's very likely that YouTube checks the isTrusted property. Therefore it makes more sense to speed up the automatic piechart timer instead. But I got no idea where to begin with this.

MartinBraquet commented 4 months ago

Got it, I opened a wiki and project to jot down ideas and interesting info, like the current status of the youtube detection algorithm (what they detect, etc). Both are aimed to be fully open access so everyone can contribute without the burden of reviewing the info. Feel free to use either of them if that helps.

MartinBraquet commented 4 months ago

I won't be looking much into this issue if we don't get many complaints from users, but feel free to look into it in the future if you have any interest.

Archaeologistflash commented 4 months ago

I think you'll get those complaints. Whether I click the skip button, or wait for the timer to go around, about 25% of the time the video loses the image and resumes with audio only. And refreshing the page sends me back to the start of the video. It's unwatchable to have to keep refreshing and then finding where I'd got to.

MartinBraquet commented 4 months ago

Are you referring to download links like above? Aren't those only in the ads at the start of the video? The video still being hidden after the ad might be unrelated to that issue. Did you activate Boost after 2s in the extension settings? In any case, you can deactivate Hide ad, and it shouldn't be an issue anymore for the time being.