Closed BluestoneDE closed 4 months ago
I'll come back tomorrow, as I'm on the central European time.
Yeah, I cannot do 12x speed with the temporary skip click workaround. 5x is good enough that it doesn't get detected and we want this extension to "work out of the box". I even allowed for the video to not get sped up at all via a new minimum for that option. I'm central European too but I care a lot less about sleep deprivation.
Alright I did a lot. Still no idea how to skip this install link problem. YouTube also detects a click simulation here because it's the same "Skip Ad" button.
Also, it would be helpful if you can write down, in this PR or another one, a few bullet points in the readme about which methods don't work anymore as of today. Knowledge of failures is also valuable knowledge, which will help guide future development.
Looks good to me. Basically you undid my changes in 5c3d34d with the default option of it being turned off. I tested this version with your changes and it works as expected.
Although, now the video won't get boosted if it is enabled with "Do Nothing" selected.
Right, boosting to the ad end should probably be done regardless of the ad skip behavior. So what you just pushed makes sense to me. Will wait for an answer in #7 . If the issue doesn't get answered, I'll merge tomorrow.
Notes
Apparently you cannot simulate clicks on the skip button anymore. I tired and at least for now we can skip the video manually by changing the
video.currentTime
. This however results in the player showing the download button for specific ads with install links. Notice the piechart timer in the top right corner. This ad goes away automatically by Youtube itself after 5 seconds. Also I neatly ordered the popup inputs into a table.Changes
SkipButton.click()
because it gets detected