MartinBruun / P6

2 stars 0 forks source link

Standardize testing and Readmes #278

Closed MartinBruun closed 2 years ago

MartinBruun commented 2 years ago

Fixes #262 Makes the necessary standardisation, so backend (web) and frontend (app) models the same domain language, making future development less error prone (make specifications for the future of the box)

Fixes #270 Sets up the coverage (is set just below each projects current coverage. Should be upped towards 100% along multiple sprints)

Before refactoring, the coverage was: app 5.9%, box 42.9% and web: 75%

Fixes #220 Reimplements flutter analyze to make for automatic linting for app

Fixes #224 Implements scripts using autopep8 and flake8 (and CI update with flake8) to check for automatic linting of box and web

Fixes #214 Makes sure that the authtoken interface is identical to the account and user interfaces

Fixes #269 Have created entities that mimic the same structure as the backend, so flutter now have a firstBooking, firstUser, etc. structure Have also created all the entities which should be used instead of models (except for remotes)

Fixes #241 Have created a WebConnector component, which handles the connection to Web, handling authorization and standardisation of connections to the Web.

Fixes #212 This also standardises how the different components work together, at least in the domain and data layer (presentation works rather well as of now, with only minor changes necessary)

Fixes #213 The current active user has been set to instead be saved in the AccountProvider, rather than being a global singleton accessible everywhere. (Ie. The AccountProvider is responsible for updating the current active user, when it activates usecases)

Fixes #230 Creates a "LanguageProvider" pr. feature, where the Language provider is simply a wrapper for a nested dictionary that contains all the text that will be shown to the enduser. This makes translation easy, as well as testing that a language has a translation for everything. Presently, only AccountLanguageProvider is implemented

Fixes #216 The DateTime currently does use UTC on the backend and the app have the ability to translate times properly. It is just necessary that the conversion happens ONLY in the WebModels that have with time. The DateHelper class should therefore be dependency injected through the repository to the models that handle datetime conversion. The models function as serializers/deserializers, so they should handle the work, and the repository is the one responsible for making the proper serialization/deserialization calls.

Fixes #218 Removes all Future.delayed since this user experience (presenting animations) should be solely controlled by the providers.

MartinBruun commented 2 years ago

Review of this should be done with looking in the code, not on github. All the files changed is because the directory structure has been reorganized.

Now, the backend and the frontend describe the same domain, meaning the application describes some bookings, something with electricity, a location and some accounts

MartinBruun commented 2 years ago

Assurance fails, because the other confidence runs have to be on master for it to properly "wait for them" to execute its workflow. If they are not on master, it simply starts running (and immiditately tells us "no previous event has been succeeding, so i fail by default" which makes sense)

MartinBruun commented 2 years ago

The washee system is closed down, and has been migrated to another project.

If anyone want to join, just contact me. This is solely done for the case of not having everything public