MartinEesmaa / VVCEasy

VVCEasy is that you don't have to compile or/and coding to encode VVC (known as Versatile Video Codec). Simple. Easy. Encode. Decode
https://martineesmaa.github.io/en/vvceasy
MIT License
160 stars 15 forks source link

Bug in modified LAV Filters #26

Closed lotharmatheos closed 1 year ago

lotharmatheos commented 1 year ago

Matroska mkv files not working with VVC modified LAVFilters

Steps to reproduce the behavior:

  1. Install LAVFilters-0.77.2-x64-VVCEasy.7z
  2. Play any mkv container file
  3. Error "Cannot render file" occurs
MartinEesmaa commented 1 year ago

Hi, @lotharmatheos! Can you tell me what media player you're using, so I can help a little bit information to find a bug?

lotharmatheos commented 1 year ago

Media Player Home Cinema 2.0 https://github.com/clsid2/mpc-hc/releases/tag/2.0.0

Original LAVFilters works. All codecs works but in mp4 container MKV has problems with LAVFilters-0.77.2-x64-VVCEasy regardless of codec (tested both 4k hdr 265 and sdr 1080p 264)

MartinEesmaa commented 1 year ago

@lotharmatheos, I just tested to play Matroska container and it works fine to me :/. Screenshot: lavfiltersoptions matroskacontainer

I think the reason is I enabled demuxer matroska of FFmpeg configuration could make problem for some machines having MKV container playing errors, the official LAVFilters build disabled demuxer matroska of FFmpeg configuration, because matroska codes is on it of LAVFilters source code. https://github.com/Nevcairiel/LAVFilters/search?q=matroska (Built matroska codes on it) https://github.com/Nevcairiel/LAVFilters/blob/master/build_ffmpeg.sh#L55 (Disabled matroska demuxer in FFmpeg LAVFilters configuration script)

Thank you for noticing the bug, I will do tomorrow later for disabling matroska demuxer of FFmpeg configuration build.

lotharmatheos commented 1 year ago

Thank you! Now it's all working.

MartinEesmaa commented 1 year ago

@lotharmatheos, you're welcome! :)