search

MartinMalinda / vue-concurrency

A library for encapsulating asynchronous operations and managing concurrency for Vue and Composition API.
https://vue-concurrency.netlify.app/
MIT License
352 stars 15 forks source link

Move vitepress to devDependencies, bump it to official v1.x.x release #105

Closed pascalwengerter closed 6 months ago

pascalwengerter commented 6 months ago

Fixes #104, also bumps Vitepress since it was still using a rc version.

I'm not a Vitepress expert by any means, but the only difference I could spot was a slightly larger top margin on the pages? Vitepress changelog notes two (unrelated) breaking changes since the formerly used release

pascalwengerter commented 6 months ago

(Side note: Also not sure if docs/.vitepress/ or docs/.vitepress/cache necessarily need to be checked in with the rest of the repo?)

MartinMalinda commented 6 months ago

Thanks a lot! I'm checking the deploy preview and it looks all right 👍

(Side note: Also not sure if docs/.vitepress/ or docs/.vitepress/cache necessarily need to be checked in with the rest of the repo?)

Ahh, judging by the number of lines changed (+14,278 −2,023), I guess no. Maybe I haven't fully followed some install instructions, it looks like the cache is something that's supposed to go to the gitignore.

Probably should be exactly the same as here: https://github.com/vitejs/vite/blob/main/.gitignore#L9

pascalwengerter commented 6 months ago

Let me update the PR then ;)

MartinMalinda commented 6 months ago

Looks great, thanks a lot 🙏