Vue3 support - Githubissues

MartinMalinda / vue-concurrency

A library for encapsulating asynchronous operations and managing concurrency for Vue and Composition API.

https://vue-concurrency.netlify.app/

MIT License

350 stars 15 forks source link

Vue3 support #22

Closed MartinMalinda closed 4 years ago

MartinMalinda commented 4 years ago

[x] make tests pass with Vue 3
[x] make tests pass both for Vue 2 and Vue 3
[x] bundle both for Vue 2 and Vue 3
[x] put both vue2 and vue3 bundle in dist and add index.js that lets the consumer choose the right one
[x] make the docs work
[x] test in Vue 2 and Vue 3 app via npm install

ghost commented 4 years ago

DeepCode's analysis on #df3761 found:

:information_source: 3 minor issues. :point_down:
Top issues

Description	Example fixes
No catch method for promise. This may result in an unhandled promise rejection. Occurrences: wait-for.ts:11	:wrench: Example fixes
Use "utf8", which Node uses, instead of "utf-8" (in fs.writeFileSync). Occurrences: postinstall.js:24 postinstall.js:25 postinstall.js:26	:wrench: Example fixes
No catch method for promise. This may result in an unhandled promise rejection. Occurrences: components.ts:26	:wrench: Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

leventekobor commented 4 years ago

❤️