MartinNohr / MagicImageWand

Paints Images in the Air with LEDs
Apache License 2.0
20 stars 7 forks source link

Standard Direction should be right to left #24

Closed dirkessl closed 3 years ago

dirkessl commented 3 years ago

When recording macros, for instance spelling a name with the fire alphabet, names need to be put in reverse in the macro menu as walking direction is reversed.

I would suggest to change the standard direction to right to left, this would also make all pixelstick images on the web compatible without rotating them 180 degrees.

Or am I missing something?

MartinNohr commented 3 years ago

Nope, I missed that one. It happened because the original design moved from right to left. I decided that it seemed more natural to move from left to right. It also made reading the images faster since I didn't have to read them in reverse, because of rotating them clockwise. Perhaps we should rotate the images counter clock wise instead of clockwise and make the default walking from right to left. I'll sleep on that idea, we can decide tomorrow. I am thinking it might be better to do it that way. Or else we have to explain to people to record macros in reverse! Probably silly.

MartinNohr commented 3 years ago

Rotating CCS means flipping top and bottom during display, but I already handle that in code and it doesn't have any time penalty. Reading the file in reverse does have a time penalty. So I am thinking we should go with CCW rotation. I seem to remember that the original Michael Ross version also rotated CCW. You'll have to change your website converter but I suspect that will be pretty simple.

MartinNohr commented 3 years ago

OK, after some thought... let's reverse all the images to CCW rotation. I'll fix the code this morning and change the docx file to document the correct direction etc. The code can handle reversing but it will make reading the file much slower. It runs almost at half speed when I tested it. Reverse file reading is not very efficient. At least we don't have thousands of users to worry about!

MartinNohr commented 3 years ago

Latest code now works as discussed above. Images need to be rotated CCW and walking is from right to left as facing the camera. You can still reverse the walk direction, there is a slight time penalty, but it isn't too bad, maybe 20% (guessing...).